-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20508] TCP first message loss (backport #4454) #4561
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #20508: add remaining add_logical_port calls Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox tests + functional fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add cv + fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508. Use lock_guard where apropiate. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Proxy is_local_port_opened. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Refactor wait_logical_port_under_negotiation. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix typo Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - firs message loss related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - transport descriptor related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Change timeout behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix xml parser Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Undo fastcdr commit change Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8103cf0) # Conflicts: # include/fastdds/rtps/transport/TCPTransportDescriptor.h # include/fastrtps/xmlparser/XMLParserCommon.h # resources/xsd/fastRTPS_profiles.xsd # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/TCPTransportInterface.h # src/cpp/rtps/xmlparser/XMLParser.cpp # src/cpp/rtps/xmlparser/XMLParserCommon.cpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/mock/rtps/TCPTransportDescriptor/fastrtps/transport/TCPTransportDescriptor.h # test/system/tools/xmlvalidation/XMLTesterExample_profile.xml # test/system/tools/xmlvalidation/all_profile.xml # test/unittest/transport/TCPv4Tests.cpp # test/unittest/transport/TCPv6Tests.cpp # test/unittest/transport/mock/MockTCPv4Transport.h # test/unittest/transport/mock/MockTCPv6Transport.h # test/unittest/xmlparser/XMLParserTests.cpp
Cherry-pick of 8103cf0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
13 tasks
Fast DDS v2.12.2 has been frozen due to its EOL. No more backports to 2.12.x are going to be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the initial TCP logical port negotiation some logical port requests were missing. This would not prevent communication as those remaining requests would be sent on the first data sent to that logical port. However, that data would be discarded.
With this PR all discovered logical ports are requested on initialization and the first data would not need to be discarded.
@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).Related documentation PR: [20508] TCP first message loss Fast-DDS-docs#699
Reviewer Checklist
This is an automatic backport of pull request #4454 done by [Mergify](https://mergify.com).