Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20508] TCP first message loss (backport #4454) #4561

Closed
wants to merge 1 commit into from

Commits on Mar 15, 2024

  1. TCP first message loss (#4454)

    * Refs #20508: add remaining add_logical_port calls
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Add unittests
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes)
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Add blackbox tests + functional fixes
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Fix tests
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Add cv + fix windows tests
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508. Use lock_guard where apropiate.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20508. Proxy is_local_port_opened.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20508. Refactor wait_logical_port_under_negotiation.
    
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    
    * Refs #20508: Apply suggestions
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Fix typo
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Apply suggestions - firs message loss related
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Apply suggestions - transport descriptor related
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Change timeout behavior
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Uncrustify
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Fix xml parser
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    * Refs #20508: Undo fastcdr commit change
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    
    ---------
    
    Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
    Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
    Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
    (cherry picked from commit 8103cf0)
    
    # Conflicts:
    #	include/fastdds/rtps/transport/TCPTransportDescriptor.h
    #	include/fastrtps/xmlparser/XMLParserCommon.h
    #	resources/xsd/fastRTPS_profiles.xsd
    #	src/cpp/rtps/transport/TCPTransportInterface.cpp
    #	src/cpp/rtps/transport/TCPTransportInterface.h
    #	src/cpp/rtps/xmlparser/XMLParser.cpp
    #	src/cpp/rtps/xmlparser/XMLParserCommon.cpp
    #	test/blackbox/common/BlackboxTestsTransportTCP.cpp
    #	test/mock/rtps/TCPTransportDescriptor/fastrtps/transport/TCPTransportDescriptor.h
    #	test/system/tools/xmlvalidation/XMLTesterExample_profile.xml
    #	test/system/tools/xmlvalidation/all_profile.xml
    #	test/unittest/transport/TCPv4Tests.cpp
    #	test/unittest/transport/TCPv6Tests.cpp
    #	test/unittest/transport/mock/MockTCPv4Transport.h
    #	test/unittest/transport/mock/MockTCPv6Transport.h
    #	test/unittest/xmlparser/XMLParserTests.cpp
    jepemi authored and mergify[bot] committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    87642e7 View commit details
    Browse the repository at this point in the history