Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20654] Increase ack waiting time in reliable_on_unack_sample_removed #4627

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[20654] Increase ack waiting time in reliable_on_unack_sample_removed #4627

merged 1 commit into from
Mar 27, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Mar 27, 2024 •
edited by EduPonz
Loading

Description

The test reliable_on_unack_sample_removed regularly fails in MacOS Github CI due to the removal of unacknowledged samples (even though they are correctly received). This pr increases the ack waiting time to allow the acknowledge and make the test pass.

@Mergifyio backport 2.13.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf
Refs #20654: Increase ack waiting time in reliable_on_unack_sample_re…
9c14f33 
…moved

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added this to the v2.14.1 milestone Mar 27, 2024
@EduPonz EduPonz self-requested a review March 27, 2024 07:58
@EduPonz
Copy link

EduPonz commented Mar 27, 2024

@richiprosima please test this

@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 27, 2024
EduPonz
EduPonz approved these changes Mar 27, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit a0bd331 into master Mar 27, 2024
11 of 15 checks passed
@EduPonz EduPonz deleted the hotfix/reliable_unack_test_fail branch March 27, 2024 13:56
@EduPonz
Copy link

EduPonz commented Mar 27, 2024

@Mergifyio backport 2.13.x 2.10.x

@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 27, 2024 •
edited
Loading

backport 2.13.x 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 27, 2024
@elianalf @mergify
Increase ack waiting time in reliable_on_unack_sample_removed (#4627)
183b9e1 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit a0bd331)
mergify bot pushed a commit that referenced this pull request Mar 27, 2024
@elianalf @mergify
Increase ack waiting time in reliable_on_unack_sample_removed (#4627)
b3bf136 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit a0bd331)
This was referenced Mar 27, 2024
Merged
Merged
EduPonz pushed a commit that referenced this pull request Mar 31, 2024
@mergify @elianalf
Increase ack waiting time in reliable_on_unack_sample_removed (#4627) (…
a18dcb3 
…#4632)

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit a0bd331)

Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Apr 1, 2024
@mergify @elianalf
Increase ack waiting time in reliable_on_unack_sample_removed (#4627) (…
0dcc20b 
…#4633)

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit a0bd331)

Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @EduPonz