Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20654] Increase ack waiting time in reliable_on_unack_sample_removed (backport #4627) #4633

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 27, 2024

Description

The test reliable_on_unack_sample_removed regularly fails in MacOS Github CI due to the removal of unacknowledged samples (even though they are correctly received). This pr increases the ack waiting time to allow the acknowledge and make the test pass.

@Mergifyio backport 2.13.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • Changes are ABI compatible.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4627 done by [Mergify](https://mergify.com).

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit a0bd331)
@MiguelCompany MiguelCompany merged commit 0dcc20b into 2.10.x Apr 1, 2024
7 of 10 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.10.x/pr-4627 branch April 1, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants