-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20542] Refactor Github CI sanitizer related jobs (backport #4662) #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of ac0e737 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
7 tasks
* Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Remove old workflows Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit ac0e737)
JesusPoderoso
force-pushed
the
mergify/bp/2.13.x/pr-4662
branch
from
April 10, 2024 05:24
765cede
to
37eafc7
Compare
JesusPoderoso
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
April 10, 2024 08:45
JesusPoderoso
force-pushed
the
mergify/bp/2.13.x/pr-4662
branch
from
April 10, 2024 08:59
7a94324
to
d554d5b
Compare
JesusPoderoso
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
April 10, 2024 08:59
JesusPoderoso
force-pushed
the
mergify/bp/2.13.x/pr-4662
branch
from
April 10, 2024 09:00
d554d5b
to
6b05673
Compare
JesusPoderoso
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
April 10, 2024 09:00
JesusPoderoso
force-pushed
the
mergify/bp/2.13.x/pr-4662
branch
from
April 10, 2024 10:00
6b05673
to
37eafc7
Compare
JesusPoderoso
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
April 10, 2024 10:00
CI has only been run for Sanitizers in this PR (due to the sanitizers refactor it implements) |
JesusPoderoso
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Apr 11, 2024
JesusPoderoso
approved these changes
Apr 17, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the Github CI for Address and Thread Sanitizers. It removes the old workflows and adds a single reusable one that defines 4 jobs:
asan_fastdds_build
asan_fastdds_test
(uses the build fromasan_fastdds_build
)asan_discovery_server_test
(uses the build fromasan_fastdds_build
)tsan_fastdds_test
Furthermore, it adds both a
sanitizers-ci.yaml
andnightly-sanitizers-ci.yaml
so that:no-test
andskip-ci
labels are not set.asan_fastdds_test
,asan_discovery_server_test
, andtsan_fastdds_test
. This way it is possible to run a subset of the jobs defined in the workflow.address_sanitizers.yaml
thread_sanitizer.yaml
@Mergifyio backport 2.13.x 2.10.x 2.6.x
IMPORTANT: Remove the nightly workflows from the backports, as they will not run anyways.
Contributor Checklist
Commit messages follow the project guidelines.
N/A: The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A: Changes are ABI compatible.
N/A: Changes are API compatible.
N/A: New feature has been added to the
versions.md
file (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4662 done by [Mergify](https://mergify.com).