-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21077] Update Fast DDS docs QoS examples #4842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
cferreiragonz
force-pushed
the
qos_api_review
branch
from
May 28, 2024 14:30
58a688b
to
2e0ed4d
Compare
cferreiragonz
force-pushed
the
qos_api_review
branch
from
June 13, 2024 15:08
2e0ed4d
to
9bcc8c0
Compare
cferreiragonz
force-pushed
the
qos_api_review
branch
from
June 14, 2024 06:28
9bcc8c0
to
c826bed
Compare
cferreiragonz
requested review from
MiguelCompany
and removed request for
MiguelCompany
June 14, 2024 06:28
Tempate
suggested changes
Jun 17, 2024
cferreiragonz
force-pushed
the
qos_api_review
branch
2 times, most recently
from
June 18, 2024 12:34
1b69764
to
b603f6c
Compare
Tempate
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
7 tasks
cferreiragonz
changed the title
[21077] Review Fast DDS docs QoS examples
[21077] Update Fast DDS docs QoS examples
Jun 19, 2024
cferreiragonz
force-pushed
the
qos_api_review
branch
from
June 19, 2024 06:57
b603f6c
to
19d5c68
Compare
Tempate
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reviews that the API of QoS is identical for all entities that share a common QoS. It also makes the PropertyPolicyQoS of DataWriters and DataReader unmutable (such as the one of Participants), until a deeper study is made on what Policies should be mutable on enabled entities.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist