Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeObjectRegistry refactor [21132] #4874

Merged
merged 22 commits into from
Jun 14, 2024
Merged

Conversation

richiware
Copy link
Member

@richiware richiware commented May 30, 2024

Description

With this refactor, any registration in TypeObjectRegistry will return a TypeIdentifierPair which a TopicDataType can use to configure internally DDS.

Next PRs depends on this one:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware force-pushed the feature/type-registry-refactor branch from 83e3470 to 87bd8a4 Compare May 30, 2024 08:04
@github-actions github-actions bot added the ci-pending PR which CI is running label May 30, 2024
@richiware richiware requested review from adriancampo and removed request for adriancampo May 30, 2024 13:11
@richiware richiware force-pushed the feature/type-registry-refactor branch from 01e31e5 to ef57049 Compare May 30, 2024 13:27
@richiware richiware requested review from adriancampo and removed request for adriancampo May 30, 2024 13:27
@richiware richiware changed the title TypeObjectRegistry refactor TypeObjectRegistry refactor [21132] Jun 3, 2024
@richiware richiware requested review from adriancampo and removed request for adriancampo June 3, 2024 07:59
@richiware richiware requested review from adriancampo and removed request for adriancampo June 5, 2024 10:27
@richiware richiware force-pushed the feature/type-registry-refactor branch from 5a86d71 to bc34343 Compare June 5, 2024 10:34
@richiware richiware requested review from adriancampo and removed request for adriancampo June 5, 2024 10:35
@richiware richiware force-pushed the feature/type-registry-refactor branch from bc34343 to 2cba6d6 Compare June 5, 2024 12:08
@richiware richiware removed the request for review from adriancampo June 5, 2024 12:08
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware force-pushed the feature/type-registry-refactor branch from 0dabcec to 56b31e2 Compare June 13, 2024 12:40
@richiware richiware requested review from adriancampo and removed request for adriancampo June 13, 2024 12:40
Copy link
Contributor

@adriancampo adriancampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz
Copy link

EduPonz commented Jun 13, 2024

@richiprosima please test_3 discovery-server

1 similar comment
@EduPonz
Copy link

EduPonz commented Jun 13, 2024

@richiprosima please test_3 discovery-server

@EduPonz EduPonz merged commit dbab57d into master Jun 14, 2024
12 of 20 checks passed
@EduPonz EduPonz deleted the feature/type-registry-refactor branch June 14, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running first-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants