Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21120] Fix EDP build warning wihtout security #4932

Merged
merged 2 commits into from
Jun 12, 2024
Merged

[21120] Fix EDP build warning wihtout security #4932

merged 2 commits into from
Jun 12, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 11, 2024

Description

This PR fixes a build warning that occurs when building Fast DDS without security, introduced in:

Added the skip-ci label (PR is by default run with security) and triggering manual CI without security

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO Changes are API compatible.
  • NO New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Jun 11, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 11, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 11, 2024
@JesusPoderoso
Copy link
Contributor Author

Manual run of Ubuntu CI (cmake args -DSECURITY=OFF, ctest args -N)

Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JesusPoderoso and others added 2 commits June 12, 2024 07:40
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Copy link

EduPonz commented Jun 12, 2024

CI passed here

@EduPonz EduPonz merged commit ae42cf7 into master Jun 12, 2024
3 checks passed
@EduPonz EduPonz deleted the hotfix/21120 branch June 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants