Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy redundunt TypeLookupSettings removed from mock #5351

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

fwae-mihir
Copy link
Contributor

@fwae-mihir fwae-mihir commented Oct 24, 2024

Description

TypeLookupSettings was used in the version 2.14.3 which is now redundant and removed from code but this structure is still hanging in the mock code. which this work removes to keep the code clean.

This fix should be done for the 3.1.x and 3.0.x other old branches are unaffected by this.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mihir Patel <mihir.patel@fortescue.com>
@JesusPoderoso
Copy link
Contributor

Hi @fwae-mihir, thanks for your contribution!

@JesusPoderoso JesusPoderoso self-requested a review October 24, 2024 09:18
@JesusPoderoso JesusPoderoso added this to the v3.2.0 milestone Oct 24, 2024
@JesusPoderoso JesusPoderoso self-assigned this Oct 24, 2024
@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Oct 24, 2024
@rsanchez15 rsanchez15 merged commit 2a1cdf6 into eProsima:master Oct 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants