model.base: Rename GlobalReference to ExternalReference
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-heppner
changed the title
GlobalReference to ExternalReferenceGlobalReference to ExternalReference
jkhsjdhjs
reviewed
Aug 20, 2023
README.md
Outdated
| id_short='ExampleProperty', # Identifying string of the element within the submodel namespace | ||
| value_type=model.datatypes.String, # Data type of the value | ||
| value='exampleValue', # Value of the property | ||
| semantic_id=semantic_reference # set the semantic reference |
There was a problem hiding this comment.
Why have these lines been re-indented with 2 spaces instead of 4?
There was a problem hiding this comment.
I have honestly no idea. Must have been PyCharm during rebasing. I reverted the indentation.
|
This should be rebased after #107 is merged and changed such that it replaces the new occurances of |
|
I've updated this branch to the newest changes in
still need to be adapted manually. @jkhsjdhjs could you do this? |
s-heppner
commented
Aug 22, 2023
s-heppner
commented
Aug 22, 2023
jkhsjdhjs
reviewed
Aug 22, 2023
s-heppner
commented
Aug 23, 2023
jkhsjdhjs
suggested changes
Aug 23, 2023
basyx/aas/model/base.py
Outdated
| @@ -777,7 +777,7 @@ class Reference(metaclass=abc.ABCMeta): | |||
| A reference is an ordered list of keys, each key referencing an element. The complete list of keys may for | |||
| example be concatenated to a path that then gives unique access to an element or entity. | |||
|
|
|||
| This is the abstract superclass of GlobalReference and ModelReference, which implements common attributes and | |||
| This is the abstract superclass of External and ModelReference, which implements common attributes and | |||
There was a problem hiding this comment.
This External should be changed to ExternalReference, as it references the class.
There was a problem hiding this comment.
Oh, I introduced this change 😂
jkhsjdhjs
force-pushed
the
Rename/GlobalReference
branch
2 times, most recently
from
0bc0134
to
1081a70
Compare
Version 3.0 of the spec renames `ReferenceTypes/GlobalReference` to `ReferenceTypes/ExternalReference` to avoid confusion with `KeyTypes/GlobalReference`.
… to `ExternalReference`
jkhsjdhjs
force-pushed
the
Rename/GlobalReference
branch
from
1081a70
to
5be0392
Compare
s-heppner
changed the title
GlobalReference to ExternalReferenceGlobalReference to ExternalReference
Frosty2500
pushed a commit
to rwth-iat/basyx-python-sdk
that referenced
this pull request
Aug 22, 2024
…ence Version 3.0 of the spec renames ReferenceTypes/GlobalReference to ReferenceTypes/ExternalReference to avoid confusion with KeyTypes/GlobalReference. This merge implements these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.0 of the spec renames
ReferenceTypes/GlobalReferencetoReferenceTypes/ExternalReferenceto avoid confusion withKeyTypes/GlobalReference.Todo: Adapt the examples in
test/compliance_tool/files.