Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model.base: Add new attributes to class AdministrativeInformation #107

Merged

Conversation

s-heppner
Copy link
Contributor

Version 3.0 of the spec introduces the 2 new attributes

  • creator
  • template_id to class AdministrativeInformation.
    This PR adds them to the class.

Todo: Adapt the adapters. @jkhsjdhjs could you do that please?

@jkhsjdhjs
Copy link
Contributor

Sure, I also just noticed that you forgot to add the _string_constraints decorator for Identifier.

Version 3.0 of the spec introduces the 2 new attributes
- `creator`
- `template_id`
to class `AdministrativeInformation`.
This commit adds them to the class.
@s-heppner s-heppner force-pushed the Expand/AdministrativeInformation branch from 0a40445 to 29e40a4 Compare August 11, 2023 13:12
@jkhsjdhjs
Copy link
Contributor

I would suggest this to be merged before #106, as this PR is already done and #107 will need to be adjusted and rebased so it changes the newly introduced GlobalReference to ExternalReference as well.

@s-heppner s-heppner changed the title WIP: model.base: Add new attributes to class AdministrativeInformation model.base: Add new attributes to class AdministrativeInformation Aug 22, 2023
@s-heppner s-heppner merged commit 3108a22 into eclipse-basyx:improve/V30 Aug 22, 2023
6 checks passed
@s-heppner s-heppner deleted the Expand/AdministrativeInformation branch August 22, 2023 18:30
@jkhsjdhjs jkhsjdhjs mentioned this pull request Aug 22, 2023
26 tasks
@s-heppner s-heppner added the v3.0 label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants