model.base: fix Referable.__repr__() for SubmodelElementList-children
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dren Since AASd-120 prohibits specifying id_shorts of direct children of `SubmodelElementLists`, this commit adjusts `Referable.__repr__()` such that the index of the element in the corresponding list is returned instead. Furthermore, the tests are adjusted accordingly.
…ue` attribute has been assigned This fixes an `AttributeError` previously raised during initialization of a `SubmodelElementList`, since the `check_constraints` function, which is called for every added item, may call `Referable.__repr__()` when the `value` attribute isn't set yet. The `AttributeError` occured because `Referable.__repr__()` accesses the `value` attribute for direct children of a `SubmodelElementList` (1aa0e82). This is worked around by first assigning the `OrderedNamespaceSet` to the `value`-attribute and then adding each item separately.
Merged
s-heppner
reviewed
Oct 3, 2023
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since AASd-120 prohibits specifying id_shorts of direct children of
SubmodelElementLists, this commit adjustsReferable.__repr__()suchthat the index of the element in the corresponding list is returned
instead.
Furthermore, the tests are adjusted accordingly.