make id_shorts optional
#130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhsjdhjs
force-pushed
the
feature/optional_id_shorts
branch
3 times, most recently
from
d62d158
to
340464a
Compare
Since `SubmodelElementLists` require that their children elements don't have `id_shorts`, they have to be made optional for all elements, but required for `NamespaceSets`.
Type is changed from `KeyError` to `AASConstraintViolation` and the tests are adjusted accordingly. Furthermore, the NamespaceSet.add() identifier uniqueness check is moved after the simple parent check for performance reasons, solely because the parent check is a lot faster.
jkhsjdhjs
force-pushed
the
feature/optional_id_shorts
branch
from
340464a
to
ee4d6ac
Compare
|
Looks good, as far as I can judge. Is it ready to be rebased? |
|
Yep 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
SubmodelElementListsrequire that their children elements don'thave
id_shorts, they have to be made optional for all elements, butrequired for
NamespaceSets.Furthermore, AASd-022 is changed from a
KeyErrortoAASConstraintViolationand thetests are adjusted accordingly.
Also, the NamespaceSet.add() identifier uniqueness check is moved
after the simple parent check for performance reasons, solely because
the parent check is a lot faster.
This PR depends on #127, #128 and #129.