Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make id_shorts optional #130

Merged
merged 3 commits into from
Oct 6, 2023
Merged

make id_shorts optional #130

merged 3 commits into from
Oct 6, 2023

Commits on Oct 4, 2023

  1. make id_shorts optional 

    Since `SubmodelElementLists` require that their children elements don't
have `id_shorts`, they have to be made optional for all elements, but
required for `NamespaceSets`.
    @jkhsjdhjs
    jkhsjdhjs committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    75f6091 View commit details
    Browse the repository at this point in the history

  2. model.base: implement AASd-022 correctly 

    Type is changed from `KeyError` to `AASConstraintViolation` and the
tests are adjusted accordingly.
Furthermore, the NamespaceSet.add() identifier uniqueness check is moved
after the simple parent check for performance reasons, solely because
the parent check is a lot faster.
    @jkhsjdhjs
    jkhsjdhjs committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    9ef348d View commit details
    Browse the repository at this point in the history

  3. model.base: implement constraint AASd-117

    @jkhsjdhjs
    jkhsjdhjs committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ee4d6ac View commit details
    Browse the repository at this point in the history