Update improve/V30RC02 with the bugfixes made to main
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unittests add: - AASReference.resolve() - Namespace.remove_referable() - NamespaceSet.__contains__()
changed testing of ref5. Due to #37 preventing the creation of a `Reference` without a key
Previously, how to contribute to Eclipse-BaSyx was not very well defined. We add an extensive contribution guideline outlining: - Issue creation - PR Workflow - Commit and PR Message Conventions and reference it in the main `README.md`. Furthermore, we move the "Codestyle and Testing" paragraph from the main `README.md` to the `CONTRIBUTING.md`.
When deserializing XML we would previously only have a look at the first child of an unnecessary wrapper element and ignore additional elements. However, since some implemenetations like the AASX Package Explorer generate schema-incompatible XML, this behavior is changed in a way such that additional elements are no longer ignored, but also parsed instead. Fix #71
Currently, we can pass a `failsafe` parameter in deserializing methods of JSON- and XML-adapters. The parameter determines whether a document should be parsed in a failsafe way. However, I cannot pass the parameter in the deserializing method of the AASX Reader because it does not have `**kwargs`. This commit adds `**kwargs` to deserializing methods of `AASXReader`, such that it is possible to pass the parameter and documents will be deserializend in a not failsafe mode.
If an assertion is contained within the same context as a statement, that raises an error, the assertion is never executed, because the raised error leaves the context.
Since a recent update, pycodestyle requires whitespaces between the last comma and the backslash at the end of a line, where it is broken.
During construction of a `Decimal`, an `InvalidOperation` exception may occur. Since the user only expects a `ValueError` from this function, because all other parsers only raise `ValueError`s, the `InvalidOperation` error-type is handled and re-raised as a `ValueError`. Fix #99
Mypy appears to not like abstract classes in a context where only concrete classes should be given: ``` Only concrete class can be given where "tuple[type[Referable], KeyTypes]" is expected ``` However, the spec demands the four abstract classes - `Event` - `DataElement` - `SubmodelElement` - `SubmodelElementCollection` to appear inside the `model.KeyTypes` Enum. Therefore, we ignore these errors via `# type: ignore`.
The AAS Manager uses typehints to generate a list of possible types for a value. Since `DateTimeStamp` was missing, it was impossible to store a `DateTimeStamp` value via AAS Manager.
s-heppner
changed the title
improve/V3.0RC02 with the bugfixes made to mainimprove/V30RC02 with the bugfixes made to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
improve/V30RC02by mergingmaininto it.This is not relevant for the upcoming v3.0 release.