Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update improve/V30RC02 with the bugfixes made to main #164

Closed
wants to merge 17 commits into from

Commits on Apr 13, 2023

  1. test.model.test_base: Add unittests to improve coverage

    unittests add:
    - AASReference.resolve()
    - Namespace.remove_referable()
    - NamespaceSet.__contains__()
    David Niebert authored and s-heppner committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f45ae7f View commit details
    Browse the repository at this point in the history
  2. add error message, removed unnecessary check

    David Niebert authored and s-heppner committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    e3fb71d View commit details
    Browse the repository at this point in the history
  3. model.test_base: Change test_resolve() in AASReferenceTest

    changed testing of ref5. Due to #37 preventing the creation of a `Reference` without a key
    David Niebert authored and s-heppner committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    7289de0 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. CONTRIBUTING.md: Add a contribution guideline (#69)

    Previously, how to contribute to Eclipse-BaSyx was not
    very well defined.
    
    We add an extensive contribution guideline outlining:
      - Issue creation
      - PR Workflow
      - Commit and PR Message Conventions
    and reference it in the main `README.md`.
    Furthermore, we move the "Codestyle and Testing" paragraph from the
    main `README.md` to the `CONTRIBUTING.md`.
    s-heppner authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d314d7c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. adapter.xml.xml_deserialization: be more forgiving with invalid input

    When deserializing XML we would previously only have a look at the first
    child of an unnecessary wrapper element and ignore additional elements.
    However, since some implemenetations like the AASX Package Explorer
    generate schema-incompatible XML, this behavior is changed in a way such
    that additional elements are no longer ignored, but also parsed instead.
    
    Fix #71
    jkhsjdhjs authored and s-heppner committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c52b46b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Configuration menu
    Copy the full SHA
    1df9c79 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Add not failsafe mode to AASX Reader

    Currently, we can pass a `failsafe` parameter in deserializing methods 
    of JSON- and XML-adapters. 
    The parameter determines whether a document should be parsed 
    in a failsafe way. However, I cannot pass the parameter 
    in the deserializing method of the AASX Reader 
    because it does not have `**kwargs`. 
    
    This commit adds `**kwargs` to deserializing methods of `AASXReader`, 
    such that it is possible to pass the parameter and documents will 
    be deserializend in a not failsafe mode.
    zrgt authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    6435c52 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. test: fix accidentally disabled tests

    If an assertion is contained within the same context as a statement,
    that raises an error, the assertion is never executed, because the
    raised error leaves the context.
    jkhsjdhjs authored and s-heppner committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b112121 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. adapter.json.json_deserialization: fix pycodestyle warnings

    Since a recent update, pycodestyle requires whitespaces between the last
    comma and the backslash at the end of a line, where it is broken.
    jkhsjdhjs authored and s-heppner committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    c356f89 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. model.datatypes: add Decimal parsing

    During construction of a `Decimal`, an `InvalidOperation` exception
    may occur. Since the user only expects a `ValueError` from this function,
    because all other parsers only raise `ValueError`s, the `InvalidOperation`
    error-type is handled and re-raised as a `ValueError`.
    
    Fix #99
    jkhsjdhjs authored and s-heppner committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0edb506 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9dd5a87 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. model.KeyTypes: Ignore mypy errors for abstract classes to be compliant

    Mypy appears to not like abstract classes in a context where only
    concrete classes should be given:
    
    ```
    Only concrete class can be given where
    "tuple[type[Referable], KeyTypes]" is expected
    ```
    
    However, the spec demands the four abstract classes
    - `Event`
    - `DataElement`
    - `SubmodelElement`
    - `SubmodelElementCollection`
    
    to appear inside the `model.KeyTypes` Enum.
    Therefore, we ignore these errors via `# type: ignore`.
    s-heppner committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    fde3776 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Configuration menu
    Copy the full SHA
    bb5cfdd View commit details
    Browse the repository at this point in the history
  2. Simplify condition

    otto-ifak authored and s-heppner committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    6fd70b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. model.datatypes: add DateTimeStamp to AnyXSDType

    The AAS Manager uses typehints to generate a list of possible types for
    a value. Since `DateTimeStamp` was missing, it was impossible to store a
    `DateTimeStamp` value via AAS Manager.
    jkhsjdhjs authored and s-heppner committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    1674911 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    4c98ba0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    662ccf6 View commit details
    Browse the repository at this point in the history