Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Update Dockerfiles to provide arm64 support #55

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

devkelley
Copy link
Contributor

Motivation and Context

Adds Dockerfiles that allow a user to build the service and samples with arm64 architecture support.

Description

  • Add Dockerfiles for arm64 support
  • Add Dockerfiles to build the samples and mosquitto mqtt broker
  • Remove containerize feature
  • Add containers.md doc that explains how to build and run containers for Docker and Podman
  • Reference containers.md in multiple READMEs

Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Please take a look.

Dockerfile Outdated Show resolved Hide resolved
docs/containers.md Outdated Show resolved Hide resolved
docs/containers.md Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@ladatz ladatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comments

Dockerfile.arm64 Outdated Show resolved Hide resolved
Dockerfile.arm64 Outdated Show resolved Hide resolved
Dockerfile.arm64 Show resolved Hide resolved
Dockerfile.samples Outdated Show resolved Hide resolved
Dockerfile.samples.arm64 Outdated Show resolved Hide resolved
Dockerfile.arm64 Outdated Show resolved Hide resolved
Dockerfile.mosquitto Outdated Show resolved Hide resolved
Dockerfile.mosquitto.arm64 Outdated Show resolved Hide resolved
Dockerfile.samples Outdated Show resolved Hide resolved
Dockerfile.samples.arm64 Outdated Show resolved Hide resolved
ladatz
ladatz previously approved these changes Nov 30, 2023
@devkelley
Copy link
Contributor Author

Link and Markdown url failure is a known issue with the workflow

@devkelley devkelley merged commit 04389e0 into main Dec 4, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants