[config] API change for ecal_config.h #1854
Conversation
…g getters into internal space.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #pragma once | ||
|
|
||
| #include <cstddef> | ||
| #include <ecal/ecal_log_level.h> |
There was a problem hiding this comment.
warning: included header cstddef is not used directly [misc-include-cleaner]
| #include <ecal/ecal_log_level.h> | |
| #include <ecal/ecal_log_level.h> |
|
|
||
| #include <cstddef> | ||
| #include <ecal/ecal_log_level.h> | ||
| #include <ecal/ecal_os.h> |
There was a problem hiding this comment.
warning: included header ecal_log_level.h is not used directly [misc-include-cleaner]
| #include <ecal/ecal_os.h> | |
| #include <ecal/ecal_os.h> |
| #include <ecal/ecal_log_level.h> | ||
| #include <ecal/ecal_os.h> | ||
| #include <ecal/ecal_tlayer.h> | ||
| #include "ecal/config/configuration.h" |
There was a problem hiding this comment.
warning: included header ecal_tlayer.h is not used directly [misc-include-cleaner]
| #include "ecal/config/configuration.h" | |
| #include "ecal/config/configuration.h" |
| #include <ecal/ecal_os.h> | ||
| #include <ecal/ecal_tlayer.h> | ||
| #include "ecal/config/configuration.h" | ||
|
|
There was a problem hiding this comment.
warning: included header configuration.h is not used directly [misc-include-cleaner]
| #include "ecal/config/configuration.h" | ||
|
|
||
| #include <string> | ||
|
|
There was a problem hiding this comment.
warning: included header string is not used directly [misc-include-cleaner]
| { | ||
| ECAL_API TransportLayer::Configuration& GetTransportLayerConfiguration (); | ||
| ECAL_API Registration::Configuration& GetRegistrationConfiguration (); | ||
| ECAL_API Monitoring::Configuration& GetMonitoringConfiguration (); |
There was a problem hiding this comment.
warning: no header providing "eCAL::Monitoring::Configuration" is directly included [misc-include-cleaner]
ecal/core/src/ecal_config_internal.h:26:
+ #include "ecal/config/monitoring.h"| ECAL_API TransportLayer::Configuration& GetTransportLayerConfiguration (); | ||
| ECAL_API Registration::Configuration& GetRegistrationConfiguration (); | ||
| ECAL_API Monitoring::Configuration& GetMonitoringConfiguration (); | ||
| ECAL_API Logging::Configuration& GetLoggingConfiguration (); |
There was a problem hiding this comment.
warning: no header providing "eCAL::Logging::Configuration" is directly included [misc-include-cleaner]
ecal/core/src/ecal_config_internal.h:26:
+ #include "ecal/config/logging.h"| ECAL_API Registration::Configuration& GetRegistrationConfiguration (); | ||
| ECAL_API Monitoring::Configuration& GetMonitoringConfiguration (); | ||
| ECAL_API Logging::Configuration& GetLoggingConfiguration (); | ||
| ECAL_API Time::Configuration& GetTimesyncConfiguration (); |
There was a problem hiding this comment.
warning: no header providing "eCAL::Time::Configuration" is directly included [misc-include-cleaner]
ecal/core/src/ecal_config_internal.h:26:
+ #include "ecal/config/time.h"| ECAL_API Monitoring::Configuration& GetMonitoringConfiguration (); | ||
| ECAL_API Logging::Configuration& GetLoggingConfiguration (); | ||
| ECAL_API Time::Configuration& GetTimesyncConfiguration (); | ||
| ECAL_API Application::Configuration& GetApplicationConfiguration (); |
There was a problem hiding this comment.
warning: no header providing "eCAL::Application::Configuration" is directly included [misc-include-cleaner]
ecal/core/src/ecal_config_internal.h:25:
- #include "ecal/config/configuration.h"
+ #include "ecal/config/application.h"
+ #include "ecal/config/configuration.h"| @@ -208,7 +208,7 @@ namespace eCAL | |||
| #if ECAL_CORE_SUBSCRIBER | |||
| sstream << "------------------------- SUBSCRIPTION LAYER DEFAULTS ------------" << '\n'; | |||
| sstream << "Layer Mode UDP MC : " << LayerMode(Config::IsUdpMulticastRecEnabled()) << '\n'; | |||
| sstream << "Drop out-of-order msgs : " << (Config::Experimental::GetDropOutOfOrderMessages() ? "on" : "off") << '\n'; | |||
| sstream << "Drop out-of-order msgs : " << (Config::GetDropOutOfOrderMessages() ? "on" : "off") << '\n'; | |||
There was a problem hiding this comment.
warning: no header providing "eCAL::Config::GetDropOutOfOrderMessages" is directly included [misc-include-cleaner]
sstream << "Drop out-of-order msgs : " << (Config::GetDropOutOfOrderMessages() ? "on" : "off") << '\n';
^
Description
Removed the experimental namespace out of ecal_config.h.
Moved some config Get functions to internal space.