Add help context for the find/replace overlay #2171
Conversation
|
|
| <description>Overlay to find and replace specified text.</description> | ||
| <topic label="Find/Replace with regular expressions" href="reference/ref-regex-find-replace.htm" /> |
There was a problem hiding this comment.
Please correct indentation (and maybe also fix the one in the context where this was copied from).
There was a problem hiding this comment.
Can you please check that the indentation is wrong in the IDE as well? Sometimes github shows some indentation wrong. This is what I see in the IDE:
There was a problem hiding this comment.
The indentation is inconsistent, which is why different viewers render different visible indentations. One line uses whitespaces and one uses tabs. In the IDE, by accident, the number of whitespaces aligns with the tab size (you could even tell the IDE to render tabs differently and would then also see a difference):
There was a problem hiding this comment.
Sorry, I didn't see that!
I have changed all tabs into four spaces
There was a problem hiding this comment.
Thanks. Unfortunately, just transforming tabs into whitespaces is not correct, as there have been combinations of whitespaces and tabs which still behaves like a single tab (e.g. 1 whitespace + 1 tab behaves like 1 tab). So there are now places with too many whitespaces.
There was a problem hiding this comment.
It looks like Eclipse has no autoformat for XML by default (??!)
I copied the file into vscode (which also doesn't autoformat XMLs by default?! I used the RedHat XML extension) and formatted it there.
There was a problem hiding this comment.
Yes, if I am not mistaken, both require (additional) extensions to (auto-)format XMLs.
Wittmaxi
force-pushed
the
MW_help_context_find_replace_overlay
branch
2 times, most recently
from
177ad21 to
32cebf4
Compare
HeikoKlare
force-pushed
the
MW_help_context_find_replace_overlay
branch
2 times, most recently
from
f02586a to
6e7f00a
Compare
Adds a help context for the find/replace overlay which links to the help context for the dialog. related to eclipse-platform/eclipse.platform.ui#2045
HeikoKlare
force-pushed
the
MW_help_context_find_replace_overlay
branch
from
6e7f00a to
4405b07
Compare
Adds a help context for the find/replace overlay which links to the help context for the dialog.
related to
eclipse-platform/eclipse.platform.ui#2045