Find/Replace Overlay: add help context to Overlay #2045
Conversation
There was a problem hiding this comment.
It makes sense to reuse the help for the find/replace dialog. Since I find it a little confusing that the help title refers to a "dialog to [...]" instead of an "overlay to [...]" or the like. Since this is easy adapt and does not produce problematic redundancies, I propose to add a find_replace_overlay_context. It has to be added here (by copy-and-adapt of the existing find_replace_dialog_context:
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/3650575d30e4d7b09158120bf66c1a0243f78154/eclipse.platform.common/bundles/org.eclipse.platform.doc.user/contexts_Workbench.xml#L509-L512
Wittmaxi
force-pushed
the
MW_add_find_replace_overlay_help_context
branch
from
7118f66 to
4d5cac8
Compare
Adds a help context for the find/replace overlay which links to the help context for the dialog. related to eclipse-platform/eclipse.platform.ui#2045
|
eclipse-platform/eclipse.platform.releng.aggregator#2171 This PR adds the help context which is now used in the newest version of this PR @HeikoKlare |
|
|
Adds a help context for the find/replace overlay which links to the help context for the dialog. related to eclipse-platform/eclipse.platform.ui#2045
Adds a help context for the find/replace overlay which links to the help context for the dialog. related to eclipse-platform/eclipse.platform.ui#2045
Adds a help context for the find/replace overlay which links to the help context for the dialog. related to eclipse-platform/eclipse.platform.ui#2045
Adds a help context for the find/replace overlay which links to the help context for the dialog. related to eclipse-platform/eclipse.platform.ui#2045
Adds a help context for the find/replace overlay which links to the help context for the dialog. related to eclipse-platform/eclipse.platform.ui#2045
Adds a help context for the find/replace overlay which links to the help context for the dialog. related to eclipse-platform/eclipse.platform.ui#2045
Add the find/replace help context to the overlay which was also used for the find/replace dialog. In particular, display help for find/replace with regex patterns. fixes eclipse-platform#1994
HeikoKlare
force-pushed
the
MW_add_find_replace_overlay_help_context
branch
from
4d5cac8 to
65de8cf
Compare
There was a problem hiding this comment.
eclipse-platform/eclipse.platform.releng.aggregator#2171 has been merged and I've successfully tested this PR based on today's I-Build containing that change.
Add the find/replace help context to the overlay which was also used for the find/replace dialog. In particular, display help for find/replace with regex patterns.
fixes #1994
