Implementation of Image to enable Multi Zoom Level Support for Win32 #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
from
e096d61 to
1df54f4
Compare
|
@fedejeanne @HeikoKlare @akoch-yatta I have created the PR for Image. You can review it now. |
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
from
1df54f4 to
1fadba5
Compare
akoch-yatta
reviewed
May 17, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/win32/org/eclipse/swt/dnd/DragSource.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
2 times, most recently
from
daa481c to
3283909
Compare
1 task
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
2 times, most recently
from
8f77101 to
084b8f8
Compare
akoch-yatta
reviewed
May 22, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
from
084b8f8 to
7722383
Compare
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
4 times, most recently
from
4953f00 to
295c87c
Compare
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
4 times, most recently
from
21d6cad to
481d8b1
Compare
1 task
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
from
481d8b1 to
694c853
Compare
Test Results 442 files ±0 442 suites ±0 11m 27s ⏱️ + 2m 44s Results for commit a01f91e. ± Comparison against base commit 78ef5a2. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
from
694c853 to
fa8e857
Compare
akoch-yatta
reviewed
Jun 10, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TreeColumn.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
4 times, most recently
from
898716d to
92aecaa
Compare
1 task
akoch-yatta
reviewed
Jun 11, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
fedejeanne
requested changes
Jun 11, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Cursor.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/internal/ImageList.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Button.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TableItem.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ToolItem.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TreeItem.java
Show resolved
Hide resolved
tests/org.eclipse.swt.tests.win32/JUnit Tests/org/eclipse/swt/graphics/ImageWin32Tests.java
Outdated
Show resolved
Hide resolved
tests/org.eclipse.swt.tests.win32/JUnit Tests/org/eclipse/swt/graphics/ImageWin32Tests.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
3 times, most recently
from
163b584 to
5e68596
Compare
fedejeanne
requested changes
Jun 13, 2024
There was a problem hiding this comment.
@amartya4256 thank you for addressing all my comments.
I tested the changes and all I could find was one missing image at the top of the window: the Eclipse icon
Can you please look into that?
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
from
5e68596 to
3b9227e
Compare
This commit implements the mean to provide different handles for an Image at different zoom levels which can be consumed by the clients. All the clients are updated to use the new method to obtain the image as per their zoom level either obtained from the widget or GC. Contributes to eclipse-platform#62 and eclipse-platform#127
amartya4256
force-pushed
the
mutli_zoom_level_image
branch
from
3b9227e to
a01f91e
Compare
fedejeanne
approved these changes
Jun 14, 2024
1 task
|
Fixed the issue with the icon of the shell. But I have also created a follow up issue which addresses the problem in the depth but it doesn't have to be the part of this PR because it addresses the usability of a method outside its scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues
Requires
Note: Only the last commit in this PR is to be reviewed. Previous commit(s) belong to the prerequisite PR(s)
Unlocks
Description
This pull request is based on the implementations of PR #1214. It extends to the native zoom which is provided within widget and propagated to GC. In this PR, we provide a map of different handles to Image for different device zoom levels as required by different monitors. The method win32_getHandle provides the appropriate handle for the scaled image as per requested by the client. The clients avail the zoom level information from the GCData and Widget (based on PR #1214 ).