Implementation of Pattern to enable multi zoom level support for win32 #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartya4256
force-pushed
the
multi_zoom_level_pattern
branch
2 times, most recently
from
4ba3d27 to
37053e2
Compare
2 tasks
amartya4256
changed the title
amartya4256
force-pushed
the
multi_zoom_level_pattern
branch
6 times, most recently
from
61b0a41 to
76e5391
Compare
akoch-yatta
reviewed
Jun 11, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_pattern
branch
2 times, most recently
from
24473af to
bc79513
Compare
fedejeanne
requested changes
Jun 14, 2024
There was a problem hiding this comment.
#1236 is merged. Rebase on master and resolve the conflicts.
amartya4256
force-pushed
the
multi_zoom_level_pattern
branch
from
bc79513 to
7748ad3
Compare
fedejeanne
requested changes
Jun 17, 2024
There was a problem hiding this comment.
@amartya4256 thank you for contributing this. I added my initial evaluation. Once these have been resolved and the basics (checklist) have been checked I can move to the testing phase.
.../org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/widgets/PatternWin32ManualTest.java
Show resolved
Hide resolved
.../org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/widgets/PatternWin32ManualTest.java
Show resolved
Hide resolved
.../org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/widgets/PatternWin32ManualTest.java
Outdated
Show resolved
Hide resolved
.../org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/widgets/PatternWin32ManualTest.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
akoch-yatta
reviewed
Jun 17, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Pattern.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_pattern
branch
2 times, most recently
from
c789fa1 to
ab6e47c
Compare
fedejeanne
requested changes
Jun 18, 2024
.../org.eclipse.swt.tests.win32/ManualTests/org/eclipse/swt/widgets/PatternWin32ManualTest.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
multi_zoom_level_pattern
branch
2 times, most recently
from
b8ba26f to
0f3c523
Compare
This commit contributes to multi zoom level support of pattern using a map of zoom levels with relevant patterns. Contributes to eclipse-platform#62 and eclipse-platform#131
fedejeanne
force-pushed
the
multi_zoom_level_pattern
branch
from
0f3c523 to
075f477
Compare
fedejeanne
previously requested changes
Jun 18, 2024
There was a problem hiding this comment.
I tested the Snippet219 and when I move from the 100% monitor to the 200% monitor I see that the region (content) is resized but the shell isn't
100%
200% (ignore the background, it's my wallpaper)
Can you please look into that @amartya4256 ?
EDIT: wrong PR --> moved to #1278 (review)
Do you mean for this PR: #1278? |
fedejeanne
dismissed
their stale review
I mistkingly requested changes that were for the PR #1278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues
Requires
Note: Only the last commit in this PR is to be reviewed. Previous commit(s) belong to the prerequisite PR(s)
Description
This PR introduces multi zoom level support of pattern using a map which maintains patterns at different zoom level. The map is used by a package protected method which is used in GC in the place where the handle of patterns are needed. Since, testing patterns automatically for how they look visually is a bit difficult, so there's a snippet created for manual testing of the same pattern at different zoom levels.