Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling combo text according to zoom level #1284

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ShahzaibIbrahim
Copy link
Contributor

@ShahzaibIbrahim ShahzaibIbrahim commented Jun 18, 2024

Registering the comboDpiChange handler and applying change manually to
text, image and arrow

Contributes to #62 and #127

HOW TO TEST (Windows only!)

  • Run the CustomControlExample with the following VM Arguments
-Dswt.autoScale=quarter
-Dswt.autoScale.updateOnRuntime=true
  • Switch to the tab "CCombo"
  • Move the window from 100 to 200 zoom level monitor
  • See if scales properly

EXPECTED BEHAVIOUR

Combo list, text and arrow should be properly scaled.

Copy link
Contributor

github-actions bot commented Jun 18, 2024

Test Results

   470 files  ±0     470 suites  ±0   7m 33s ⏱️ -43s
 4 135 tests ±0   4 127 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 336 runs  ±0  16 244 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit a4979ae. ± Comparison against base commit 5cdf331.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahzaibIbrahim the code looks OK but I tested and found out that the elements of the list are displayed far away from the combo.

image

Can you please look into that?

@ShahzaibIbrahim
Copy link
Contributor Author

Can you please look into that?

@fedejeanne I have fixed the issue. Could you please check it again in both cases? (100 -> 200) and (200 ->100)

Copy link
Contributor

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it looks fine. I just have a question regarding the moving of the class outside of the package internal

@ShahzaibIbrahim ShahzaibIbrahim marked this pull request as draft June 26, 2024 09:56
@ShahzaibIbrahim ShahzaibIbrahim force-pushed the master branch 3 times, most recently from 853e7a0 to 2e1e202 Compare June 26, 2024 10:14
@ShahzaibIbrahim ShahzaibIbrahim marked this pull request as ready for review June 26, 2024 10:24
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the changes look good. The comments of Andreas and me should be rather easy to address.

@HeikoKlare
Copy link
Contributor

@fedejeanne please check if you still request changes or may drop your change request

@fedejeanne fedejeanne dismissed their stale review June 28, 2024 09:37

My comments were addressed, thank you!

@ShahzaibIbrahim ShahzaibIbrahim marked this pull request as draft June 28, 2024 10:28
@ShahzaibIbrahim ShahzaibIbrahim marked this pull request as ready for review June 28, 2024 13:11
Registering the comboDpiChange handler and applying change manually to
text, image and arrow and popup
@fedejeanne fedejeanne merged commit e138ae3 into eclipse-platform:master Jul 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants