Refactoring autoScaleUp with zoom to scaleUp #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
reviewed
Jul 12, 2024
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
rename_autoScale
branch
from
5c160ad to
c82deeb
Compare
|
@HeikoKlare Should I also do the changes for autoScaleBounds in the same PR? Since its just refactoring and done by the IDE anyways. |
amartya4256
force-pushed
the
rename_autoScale
branch
from
c82deeb to
ebd3057
Compare
Let's keep the PR's scope as small as possible and have separate PRs for other (similar) refactorings. That's easier to review and allows to revert less changes (if necessary). |
HeikoKlare
force-pushed
the
rename_autoScale
branch
from
ebd3057 to
1654d59
Compare
HeikoKlare
force-pushed
the
rename_autoScale
branch
from
1654d59 to
7e5a232
Compare
HeikoKlare
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Change looks good and is ready to merge from my side.
However, let's wait with merging anything Windows-HiDPI-related until we found the reasons for Windows I-Build failures related to SWT: #1344
amartya4256
force-pushed
the
rename_autoScale
branch
from
7e5a232 to
1e12f10
Compare
This commit contributes to the renaming of methods DPIUtil.autoScaleUp containing int zoom as an argument to DPIUtil.scaleUp, since the scaling is not done automatically but based on the zoom level which is provided. Contributes to eclipse-platform#62 and eclipse-platform#127
HeikoKlare
force-pushed
the
rename_autoScale
branch
from
1e12f10 to
595888c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to the renaming of methods DPIUtil.autoScaleUp containing int zoom as an argument to DPIUtil.scaleUp, since the scaling is not done automatically but based on the zoom level which is provided.
Contributes to #62 and #127