testFirstTabIsActivatedByDefault is no more passing with SWT fix for issue #46

[deepika-u]

Fixes #1239

With the swt fix for eclipse-platform/eclipse.platform.swt#46 via pr eclipse-platform/eclipse.platform.swt#1044 we are seeing propagateTabActivation() is not being called on all platforms.

For more details please see -> eclipse-platform/eclipse.platform.swt#46 (comment)

[github-actions]

Test Results

 1 708 files   -  23   1 708 suites   - 23   1h 20m 44s ⏱️ - 3m 43s
 4 005 tests ±  0   3 981 ✅  -   2   22 💤 ±0  2 ❌ +2 
12 383 runs   - 229  12 216 ✅  - 235  161 💤 ±0  6 ❌ +6 

For more details on these failures, see this check.

Results for commit 40e87c6. ± Comparison against base commit 50a95d9.

♻️ This comment has been updated with latest results.

[fedejeanne]

The current changes would break some existing functionality. I'd like to establish some expected behavior for LaunchConfigurationTabGroupViewer and for its setActiveTab method before moving forward with this PR and with the fix in SWT (eclipse-platform/eclipse.platform.swt#1044, eclipse-platform/eclipse.platform.swt#1164)

[deepika-u]

The current changes would break some existing functionality. I'd like to establish some expected behavior for LaunchConfigurationTabGroupViewer and for its setActiveTab method before moving forward with this PR and with the fix in SWT (eclipse-platform/eclipse.platform.swt#1044, eclipse-platform/eclipse.platform.swt#1164)

Hi @fedejeanne
I tried the below steps, can you try the same and confirm please? Sorry for the late reply as i was facing some workspace issue i took some time to get that sorted out.

1. I have updated to latest eclipse(7th Apr build) and all the repos upto date

---

Eclipse SDK
Version: 2024-06 (4.32)
Build id: I20240407-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Oracle Corporation
Java runtime version: 22+36-2370
Java version: 22

2. Applied no prs here and seeing that "all the test cases are passing".
   ->
   

3. Applied swt pr alone # 1164 and seeing below couple of failures.
   ->
   

4. Applied swt pr # 1164 , platform pr testFirstTabIsActivatedByDefault is no more passing with SWT fix for issue #46 #1287 and seeing "all test cases are passing". Then proposed the pr.
   ->
   

These are the only steps i tried and as the screenshots show, with both the prs in place i am seeing all the test cases are passing. Please confirm if the same works for you?

[fedejeanne]

Please confirm if the same works for you?

You're missing the point, it's important that no unnecessary (de)activations of tabs occur once you apply the fix (see my comment: https://github.com/eclipse-platform/eclipse.platform/pull/1287/files#r1553193527).

I added some tests to make sure of that: #1298

Those test don't pass if you apply eclipse-platform/eclipse.platform.swt#46 + #1287

[fedejeanne]

This was resolved in #1346

[deepika-u]

Thanks fedejeanne.