Fix Cut Off Label on Welcome Page

[BeckerWdf]

Fixes: eclipse-platform/eclipse.platform.ui#1210

[github-actions]

Test Results

       42 files  +       6         42 suites  +6   1h 6m 45s ⏱️ + 18m 10s
  3 778 tests +1 035    3 775 ✔️ +1 036    3 💤 ±0  0 ❌  - 1 
11 337 runs  +3 105  11 310 ✔️ +3 106  27 💤 ±0  0 ❌  - 1 

Results for commit 580255b. ± Comparison against base commit cfb3c5f.

♻️ This comment has been updated with latest results.

[BeckerWdf]

What's the error in https://ci.eclipse.org/platform/job/eclipse.platform/job/PR-745/1/console and https://github.com/eclipse-platform/eclipse.platform/pull/745/checks?check_run_id=17824396581
Can somebody pls. explain?

[iloveeclipse]

What's the error in https://ci.eclipse.org/platform/job/eclipse.platform/job/PR-745/1/console and https://github.com/eclipse-platform/eclipse.platform/pull/745/checks?check_run_id=17824396581 Can somebody pls. explain?

Please rebase your change on top of master. It's based on too old platform repo state.

[BeckerWdf]

@iloveeclipse: Can I merge this?

[iloveeclipse]

@iloveeclipse: Can I merge this?

If you explain what the patch is doing :-)
I see you've removed some code - why?

[BeckerWdf]

@iloveeclipse: Can I merge this?

If you explain what the patch is doing :-) I see you've removed some code - why?

This fixed the described bug in eclipse-platform/eclipse.platform.ui#1210.
Before this change the HTML for the "Go to Workbench" link on the welcome page looked like this:

            <DIV id="action-links">
                <A id="workbench" href="http://org.eclipse.ui.intro/switchToLaunchBar" class="right">
                    <IMG src="file:///Users/d021678/git/eclipse.platform/ua/org.eclipse.ui.intro/icons/blank.gif" alt="" class="background-image">
                    <IMG src="file:///Users/d021678/git/eclipse.platform/ua/org.eclipse.ui.intro/icons/blank.gif" alt="Go to the workbench" id="workbench_img" title="" class="content-img">
                    <DIV class="link-extra-div"></DIV>
                        <SPAN class="link-label">Hide</SPAN>
                            <P><SPAN class="text">Go to the workbench</SPAN></P>
                </A>
            </DIV>

Note the two "blank.gif" images. This caused the link to not be rendered correctly.

With my change the html now looks like this.

            <DIV id="action-links">
                <A id="workbench" href="http://org.eclipse.ui.intro/switchToLaunchBar" class="right">
                    <IMG src="file:///Users/d021678/git/eclipse.platform/ua/org.eclipse.ui.intro/icons/blank.gif" alt="Go to the workbench" id="workbench_img" title="" class="content-img">
                    <DIV class="link-extra-div"></DIV>
                        <SPAN class="link-label">Hide</SPAN>
                            <P><SPAN class="text">Go to the workbench</SPAN></P>
                </A>
            </DIV>

And now it's rendered correctly.

[iloveeclipse]

Note the two "blank.gif" images.

I've missed that. Where is the second one is coming from?

[BeckerWdf]

Note the two "blank.gif" images.

I've missed that. Where is the second one is coming from?

From the line below by deletion. But it's needed. I tried to removed it. The code it quite hard to understand. So I just did the minimum needed steps to fix the bug.

[iloveeclipse]

Thanks Matthias.