GH-5151: use VALUES clause for FedX bind join with no free vars #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For evaluation of bind joins the implementation for quite some time makes use of a VALUES clause query. Except for one code-path: for bind joins - where in the join all arguments are bound - it was still using the old UNION query approach. This approach is error prone and no longer required, i.e. the check join can be executed with the same logic as the regular VALUES clause. Note: an additional unit test for covering bind joins with no free vars is added. This change also marks a number of methods and classes used for the old UNION based approach as deprecated. The implementations are internal to the FedX engine and can be removed in the next major release.
aschwarte10
commented
Oct 29, 2024
| expr = new CheckStatementPattern(stmt, queryInfo); | ||
| taskCreator = new CheckJoinTaskCreator(strategy, (CheckStatementPattern) expr); | ||
| } | ||
| taskCreator = new BoundJoinTaskCreator(strategy, stmt); |
There was a problem hiding this comment.
this is the relevant functional change: the VALUES based implementation can also be used for bind joins without free variables without functional change.
Note that in very early versions (where the bind join was implemented with a UNION construct) there was a need to distinguish the cases. This is a left over
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #GH-5151
For evaluation of bind joins the implementation for quite some time
makes use of a VALUES clause query.
Except for one code-path: for bind joins - where in the join all
arguments are bound - it was still using the old UNION query approach.
This approach is error prone and no longer required, i.e. the check join
can be executed with the same logic as the regular VALUES clause.
Note: an additional unit test for covering bind joins with no free vars
is added.
This change also marks a number of methods and classes used for the old
UNION based approach as deprecated. The implementations are internal to
the FedX engine and can be removed in the next major release.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)