Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-5151: use VALUES clause for FedX bind join with no free vars #5165

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

GH-5151: use VALUES clause for FedX bind join with no free vars #5165

wants to merge 1 commit into from

Commits on Oct 29, 2024

  1. GH-5151: use VALUES clause for FedX bind join with no free vars 

    For evaluation of bind joins the implementation for quite some time
makes use of a VALUES clause query.

Except for one code-path: for bind joins - where in the join all
arguments are bound - it was still using the old UNION query approach.
This approach is error prone and no longer required, i.e. the check join
can be executed with the same logic as the regular VALUES clause.

Note: an additional unit test for covering bind joins with no free vars
is added.

This change also marks a number of methods and classes used for the old
UNION based approach as deprecated. The implementations are internal to
the FedX engine and can be removed in the next major release.
    @aschwarte10
    aschwarte10 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    095d478 View commit details
    Browse the repository at this point in the history