Fix plugin version comparison

[msujew]

What it does

Closes #13904

I'm confused by how this wasn't caught earlier. Even though our method was supposed to return gte, it did run lte internally. I've simply adjusted the called method to match the name and documentation. See also:

How to test

Try installing the Astro VS Code extension via the vsx-registry view. It should work as expected.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[rschnekenbu]

I remember discussing that point when reviewing #13118. I'll have a double check then.

[rschnekenbu]

I think we will have an issue for builtins if we fix this bug.
See #13118 (comment). With the existing implementation, we check the builtins version is lower than our API compatibility version.

I would suggest to change the order of the parameters here:

theia/dev-packages/ovsx-client/src/ovsx-api-filter.ts

Line 111 in 1491cd1

return getLatestCompatibleVersion(allVersions => this.versionGreaterThanOrEqualTo(allVersions.version, this.supportedApiVersion));

. If not, we will finally install builtins with a version greater than our API compatibility.

[rschnekenbu]

Looks good to me! I could install astro (latest version) and also I could have Github builtin 1.88.1 installed.