Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cohesion identify event firing, modify ConversionTracked #32

Merged

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Nov 11, 2024

  • Adding the identify call to provide the identify stitching between Cohesion and Segment.
  • Adding a type check to make sure the data sent is always a string since this is what Cohesion expects. Red Ventures data team needs the course key as a workaround to map out the course variant that is not possible to do with the data we have in the basket related to "type".
  • Modify the getCorrelationId helper, adding the domain.

@julianajlk julianajlk requested a review from a team as a code owner November 13, 2024 21:59
@julianajlk julianajlk changed the title feat: Cohesion identify event firing feat: Cohesion identify event firing and courseKey to ConversionTracked Nov 13, 2024
@julianajlk julianajlk changed the title feat: Cohesion identify event firing and courseKey to ConversionTracked feat: Cohesion identify event firing, modify ConversionTracked Nov 13, 2024
@julianajlk julianajlk force-pushed the julianajlk/EDX-1425/rv-eventing-identification-segment branch from 22f0880 to 4c33d86 Compare November 13, 2024 23:29
@julianajlk julianajlk merged commit 70da326 into master Nov 14, 2024
4 checks passed
@julianajlk julianajlk deleted the julianajlk/EDX-1425/rv-eventing-identification-segment branch November 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants