bugfix: changed TIMING_VIOLATION_CORNERS to a PDK variable (#609)

## Steps * `Checker.*Violations` * Changed `TIMING_VIOLATION_CORNERS` to a PDK variable
efabless · Dec 3, 2024 · 20bf88a · 20bf88a
1 parent 5ba0bd2
commit 20bf88a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 2 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -13,6 +13,14 @@
 ## API Breaks
 ## Documentation
 -->
+# 2.2.8
+
+## Steps
+
+* `Checker.*Violations`
+
+  * Changed `TIMING_VIOLATION_CORNERS` to a PDK variable
+
 # 2.2.7
 
 ## Steps

diff --git a/openlane/config/pdk_compat.py b/openlane/config/pdk_compat.py
@@ -228,6 +228,7 @@ def process_sta(key: str):
             ]
 
         new["DEFAULT_CORNER"] = f"nom_{default_pvt}"
+        new["TIMING_VIOLATION_CORNERS"] = ["*tt*"]
         new["LIB"] = lib_sta
 
     # x4. Constraints (sky130/gf180mcu)

diff --git a/openlane/steps/checker.py b/openlane/steps/checker.py
@@ -464,7 +464,7 @@ def __init_subclass__(cls, **kwargs):
                 cls.base_corner_var_name,
                 List[str],
                 "A list of wildcards matching IPVT corners to use during checking for timing violations.",
-                default=["*tt*"],
+                pdk=True,
                 deprecated_names=["TIMING_VIOLATIONS_CORNERS"],
             ),
             cls.get_corner_variable(),

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "openlane"
-version = "2.2.7"
+version = "2.2.8"
 description = "An infrastructure for implementing chip design flows"
 authors = ["Efabless Corporation and Contributors <donn@efabless.com>"]
 readme = "Readme.md"

diff --git a/test/steps/excluded_step_tests b/test/steps/excluded_step_tests
@@ -0,0 +1,2 @@
+checker.holdviolations/004-success-hold-overwrite
+checker.holdviolations/005-fail-different-corner
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		checker.holdviolations/004-success-hold-overwrite
		checker.holdviolations/005-fail-different-corner