Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Steps to Create Obstructions #225

Merged
merged 17 commits into from
Oct 23, 2023
Merged

Add Steps to Create Obstructions #225

merged 17 commits into from
Oct 23, 2023
+233 −59

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Oct 18, 2023 •
edited by donn
Loading

  • Created the following obstruction
    • Odb.AddRoutingbstructions: Base step for adding obstructions to a design
    • Odb.RemoveRoutingObstructions: Base step for removing obstructions from a design.
      • The preceding two steps, and their derivatives, should be used in tandem, i.e., obstructions should be added then removed later in the flow.
    • Odb.AddPDNObstructions: Inherits from Odb.AddRoutingObstructions. Runs before PDN generation.
    • Odb.RemovePDNObstructions: Inherits from Odb.RemoveRoutingObstructions. Runs after PDN generation.
  • Added validation for obstruction commands in defutil.py
  • Added exit codes for validation errors in obstruction commands in defutil.py
  • Added a command to remove obstructions to defutil.py
  • Enhanced obstructions regex matching to account for >5 items in an obstruction definition.
  • Propagated exit code when raising StepError due to Subprocess error.
  • Added unit tests for the add PDN obstructions step:
    • success
    • fail - Metal layer not found
    • fail - Wrong format: >5 items in obstruction
    • fail - Wrong format: alphanumeric coordinates
  • Added unit tests for remove PDN obstructions step:
    • success
    • fail - Metal layer not found
    • fail - Wrong format: >5 items in obstruction
    • fail - Wrong format: alphanumeric coordinates
    • fail - Obstruction not found
  • Added default Toolbox when Toolbox is not defined for a step
  • Removed missing Toolbox unit test.
  • Added output dir argument for create_test
  • Added step dir option for create_test
  • Delete "run_ol.sh" in create_test output directory

Fixes #67

Depends on efabless/openlane2-step-unit-tests#1

@donn donn changed the title add the following steps Add steps to create obstructions Oct 18, 2023
@donn donn changed the title Add steps to create obstructions Add Steps to Create Obstructions Oct 19, 2023
@kareefardi kareefardi marked this pull request as ready for review October 22, 2023 14:51
@donn
Copy link
Member

donn commented Oct 22, 2023

did you test out of bounds obstructions?

@kareefardi
Copy link
Collaborator Author

did you test out of bounds obstructions?

Yes

@kareefardi @donn
add the following steps
5d7300a 
odb.AddObstructions
odb.RemoveObstructions
odb.AddPDNObstructions
odb.RemovePDNObstructions
@kareefardi @donn
break not pass
f2fd425
@kareefardi @donn
lint
bcf7888
@kareefardi @donn
exit when layer is not found
c201d3a
@kareefardi @donn
different exit codes depending on captured error
a0ff9c3
@kareefardi @donn
add unit tests for odb.addpdnobstructions
3289d82
@kareefardi @donn
formatting
c45c372
@kareefardi @donn
consistency with error messages
b3e7120
@kareefardi @donn
format
3cc5db5
@kareefardi @donn
rename AddObstructions to AddRoutingObstructions
36fc357 
rename RemoveObstructions to RemoveRoutingObstructions
@kareefardi @donn
Add underlying_error property to StepError
a663537 
Use that property in AddPDNObstructions unit tests
@kareefardi @donn
RemoveRoutingObstructions inherits from AddRoutingObstructions
9e04a4b 
append test path to python path
quit on obstruction not found in remove_obstructions
add odbpy scripts to PYTHONPATH when running odbpy scripts
@kareefardi @donn
add more tests
0cec2de
@kareefardi @donn
remove test
6c93301
@kareefardi @donn
Document the format of obstructions [skip ci]
9c178fa
@kareefardi @donn
we have two classic flows
3432f5a
@kareefardi @donn
added output dir for create_test
7a9a864 
added step dir argument for create_test
create_test removes "run_ol.sh" automatically
@donn donn force-pushed the pdn-obstructions branch from d31966a to 7a9a864 Compare October 23, 2023 13:56
@donn donn merged commit fe25022 into main Oct 23, 2023
68 checks passed
@donn donn deleted the pdn-obstructions branch October 23, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDN Obstructions
2 participants
@kareefardi @donn