Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare back-transformation analysis pipeline needs reorganising - duplicated components #104

Closed
egouldo opened this issue Aug 12, 2024 · 1 comment · Fixed by #112
Closed

prepare back-transformation analysis pipeline needs reorganising - duplicated components #104

egouldo opened this issue Aug 12, 2024 · 1 comment · Fixed by #112
Assignees
@egouldo
Labels
breaking change ☠️ API change likely to affect existing code manuscript upkeep maintenance, infrastructure, and similar
Milestone
Software Manuscri...

Comments

@egouldo
Copy link
Owner

egouldo commented Aug 12, 2024

  • prepare_ManyEcoEvo_yi() calls clean_response_transformation()
  • back_transform_response_vars_yi() calls assign_transformation_type() and convert_predictions()
  • standardise_response() calls assign_transformation_type() and convert_predictions(), seems to duplicate the workflow in back_transform_response_vars_yi()
@egouldo egouldo added manuscript breaking change ☠️ API change likely to affect existing code upkeep maintenance, infrastructure, and similar labels Aug 12, 2024
@egouldo egouldo added this to the Software Manuscript Submit milestone Aug 12, 2024
@egouldo egouldo self-assigned this Aug 12, 2024
@egouldo egouldo mentioned this issue Aug 12, 2024
Closed
@egouldo
Copy link
Owner Author

egouldo commented Aug 12, 2024

Note that this needs to be addressed first in order to deal with #88

egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
Fix #104 reorganise yi computational pipeline in prep for #88
5a101e2 
- #104 mv `assign_transformation_type()` and `convert_predictions()` out of `standardise_response()` into `back_transform_response_vars_yi()`
- Call `back_transform_response_vars_yi()` in `prepare_response_variables()` for yi workflow (was not being called currently) #104
- #104 keep addition of `param_table` inside `standardise_response()`
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 group by id_col
2d7eddd
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 #97 make join_by argument explicit
875c483
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 fix bugs in prepare_response_variable()
4d09240 
- don't return out early (after backtransformation, need to standardise still!) #104
- standardise on the results of backtransformation `out`, if applied, and if not, use `out` prior to backtransformation, and backtransform on original `out` #104
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 fix conditional evaluation to trigger convert_predictions() / …
00c210b 
…`standardise_response()`

- incorrect use of pipe operator returned TRUE when one expression eval'd to TRUE, but we want it to return FALSE if *any* exprs eval to FALSE.
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 update comment
9fe0437
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 ungroup results of back_transform_response_vars_yi() and `stan…
7ce4e8c 
…dardise_response()`
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 use input argument dataset, not column in input arg dat, as …
7c0853f 
…`dat` may or may not have the required `dataset` column.
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 update pointblank data check
824ffa0 
- don't expect any identifier col other than `id_col` exists
- don't expect `transformation`, or `response_transformation_status` exists
- expect `response_variable_name` exists
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#59 update vignette to reflect #104 updates
1746fbf
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#104 #97 devtools::document()
6222c19
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
#97 #104 tar_make()
495e0f0
@egouldo egouldo mentioned this issue Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egouldo egouldo

Labels
breaking change ☠️ API change likely to affect existing code manuscript upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
Software Manuscript Submit
Development

Successfully merging a pull request may close this issue.

Fix #88 conditionally apply standardisation to datasets egouldo/ManyEcoEvo
1 participant
@egouldo