Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/http_endpoint: add support for base64-encoded HMAC headers #39655

Merged
merged 2 commits into from
May 30, 2024
Merged

x-pack/filebeat/input/http_endpoint: add support for base64-encoded HMAC headers #39655

merged 2 commits into from
May 30, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 21, 2024

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify Team:Security-Service Integrations Security Service Integrations Team labels May 21, 2024
@efd6 efd6 self-assigned this May 21, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 21, 2024
@efd6 efd6 force-pushed the e21680-http_endpoint branch 3 times, most recently from bd10ab4 to 5013ab2 Compare May 22, 2024 00:11
@efd6 efd6 marked this pull request as ready for review May 22, 2024 01:57
@efd6 efd6 requested a review from a team as a code owner May 22, 2024 01:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 mentioned this pull request May 26, 2024
Merged
4 tasks
andrewkroh
andrewkroh approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify Mergify
Copy link
Contributor

mergify bot commented May 30, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b e21680-http_endpoint upstream/e21680-http_endpoint
git merge upstream/main
git push upstream e21680-http_endpoint

andrewkroh
andrewkroh reviewed May 30, 2024
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case somewhere that exercises this.

@efd6 efd6 enabled auto-merge (squash) May 30, 2024 22:34
@efd6 efd6 merged commit 23f69f7 into elastic:main May 30, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh