Use Mac Developer certificate for development sign #183
Conversation
| debuglog('Finding `Developer ID Application` certificate for distribution outside the Mac App Store...') | ||
| promise = findIdentitiesAsync(opts, 'Developer ID Application:') | ||
| debuglog('Finding `Mac Developer` certificate to sign app for development...') | ||
| promise = findIdentitiesAsync(opts, 'Mac Developer:') |
There was a problem hiding this comment.
I don't think I have a "Mac Developer" cert, if this is a new thing we probably need to fall back to the old thing
There was a problem hiding this comment.
Mac Developer cert is the local certificate for each machine and has been the one we use for signing the mas dev versions. This would make it a little easier by default for folks without the Developer ID Application certs on their local machine.
Also I think this could help distinguish code signing for distribution more as app notarization only works with Developer ID Application signed apps.
I'm imagining that this shouldn't pose issues for existing toolchains people set up to distribute their apps since this only affects the dev side 🤔
There was a problem hiding this comment.
In 2020 we have two more certs #227 So I think it is time to change the defaults 😉
sethlu
force-pushed
the
use-development-certificate
branch
from
1249f7d
to
a4049b2
Compare
|
Note: Accidentally committed on the wrong branch. |
|
Any chance to have it merged? |
|
Conflicting with the rewrite, if this change is still applicable please raise a new pull request. Apologies for the conflicts |
Instead of using
Developer ID Applicationcertificates to code sign development versions of app for distribution outside the Mac App Store, we useMac Developercertificates. The updated matrix is the following:3rd Party Mac Developer ApplicationDeveloper ID ApplicationMac DeveloperMac Developer(changed)