Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle own titlebuttons #100

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Handle own titlebuttons #100

merged 8 commits into from
Mar 21, 2024

Conversation

danirabbit
Copy link
Member

Screenshot from 2024-03-01 10 06 51

@danirabbit danirabbit mentioned this pull request Mar 1, 2024
Merged
20 tasks
@danirabbit

This comment was marked as resolved.

Sign in to view
@danirabbit danirabbit mentioned this pull request Mar 14, 2024
Merged
@danirabbit danirabbit requested a review from a team March 18, 2024 18:29
@danirabbit danirabbit marked this pull request as ready for review March 18, 2024 18:29
leolost2605
leolost2605 requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a little nice to have would be if the search entry automatically gets focus it's revealed :)

@danirabbit danirabbit requested a review from leolost2605 March 21, 2024 17:14
@danirabbit
Copy link
Member Author

@leolost2605 done!

@danirabbit danirabbit merged commit 468dea7 into main Mar 21, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/handle-titlebuttons branch March 21, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @leolost2605