-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppSettingsView: don't block settings when DND is active #102
Conversation
@jeremypw when you first open settings, try resizing vertically. Then open this pane and see that it forces the window height larger in main |
@danirabbit Ah, OK - I see the issue now. I'll review again. It also happens with several other plugs if you make the initial height small enough. Maybe there should be a reasonable minimum height of the main window, which all the plugs can fit in? At the moment it can be made nearly the same height as the headerbar. |
I'm not sure what that value should be but I'm not opposed to adding a minimum window height 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremypw I saw that too. I don't think there's anything I can do here about that since it seems like a GTK bug |
@jeremypw looks like this also happens in Network settings |
Yes, I now see it happening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works well.
Fixes #91
Prevents blocking settings when DND is active
I know InfoBar is deprecated but we use it a lot so I think we probably will need a Granite replacement so I'm using it assuming we'll fix all infobars at once later.