Spelling: Adjust, the #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comradekingu
commented
Jul 3, 2021
comradekingu
commented
Jul 3, 2021
src/Plug.vala
Outdated
| @@ -25,7 +25,7 @@ public class NotificationsPlug : Switchboard.Plug { | |||
|
|
|||
| var description = _("Notifications preferences are for configuring which apps make use of notifications, for changing how an app's notifications appear,\nand for setting when you do not want to be disturbed by notifications."); | |||
| description += "\n\n"; | |||
| description += _("When apps are installed that have notification options they will automatically appear here."); | |||
| description += _("When apps with notification options are installed, they appear here."); | |||
There was a problem hiding this comment.
danirabbit
requested changes
Jul 7, 2021
src/Plug.vala
Outdated
| @@ -43,7 +43,7 @@ public class NotificationsPlug : Switchboard.Plug { | |||
| Object (category: Category.PERSONAL, | |||
| code_name: "io.elementary.switchboard.notifications", | |||
| display_name: _("Notifications"), | |||
| description: _("Configure notification bubbles, sounds, and notification center"), | |||
| description: _("Adjust notification bubbles, sounds, and the notification center"), | |||
There was a problem hiding this comment.
Oh this is a tough one. I'm not sure that "configure" or "adjust" sound completely right here. To me, "adjust" implies that there is some kind of granular control, but what we're really doing is very binary in terms of turning bubbles and sounds on or off and either allowing or disallowing them in the notification center. I'm not sure I have a great suggestion on how to improve this, but I'm not sure that this is a large enough improvement to invalidate existing translations
danirabbit
approved these changes
Oct 13, 2023
danirabbit
added a commit
that referenced
this pull request
Oct 13, 2023
Co-authored-by: Danielle Foré <danielle@elementary.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.