Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling: Adjust, the #81

Merged
merged 7 commits into from
Oct 13, 2023
+1 −1
Merged

Spelling: Adjust, the #81

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
201f45d
Spelling: Adjust, the
comradekingu Jul 3, 2021
8dc45c6
Spelling: -are installed, -automatically
comradekingu Jul 3, 2021
26a5d3e
Spelling: improvement
comradekingu Jul 3, 2021
9faee15
Update src/Plug.vala
danirabbit Oct 13, 2023
19cb70f
Update Plug.vala
danirabbit Oct 13, 2023
4033651
Update Plug.vala
danirabbit Oct 13, 2023
84d2190
Merge branch 'master' into patch-1
danirabbit Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Plug.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class NotificationsPlug : Switchboard.Plug {

var description = _("Notifications preferences are for configuring which apps make use of notifications, for changing how an app's notifications appear,\nand for setting when you do not want to be disturbed by notifications.");
description += "\n\n";
description += _("When apps are installed that have notification options they will automatically appear here.");
description += _("When apps with notification options are installed, they appear here.");
comradekingu marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with https://github.com/elementary/switchboard-plug-applications/pull/160/files#diff-fdfe5907007eb415c92fa5ac9b9b8347066dd5fb4184d62d58645c6d10267892R45


var icon_name = "dialog-information";

Expand All @@ -43,7 +43,7 @@ public class NotificationsPlug : Switchboard.Plug {
Object (category: Category.PERSONAL,
code_name: "io.elementary.switchboard.notifications",
display_name: _("Notifications"),
description: _("Configure notification bubbles, sounds, and notification center"),
description: _("Adjust notification bubbles, sounds, and the notification center"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is a tough one. I'm not sure that "configure" or "adjust" sound completely right here. To me, "adjust" implies that there is some kind of granular control, but what we're really doing is very binary in terms of turning bubbles and sounds on or off and either allowing or disallowing them in the notification center. I'm not sure I have a great suggestion on how to improve this, but I'm not sure that this is a large enough improvement to invalidate existing translations

icon: "preferences-system-notifications",
supported_settings: settings);
}
Expand Down