Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appearance: use current wallpaper on light/dark preview #399

Merged
merged 5 commits into from
May 18, 2024
Merged

Appearance: use current wallpaper on light/dark preview #399

merged 5 commits into from
May 18, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 17, 2024 •
edited
Loading

Screenshot from 2024-05-17 15 20 38

  • Use Gtk.Picture to draw wallpaper preview
  • Use an aspect frame and match the aspect ratio of the current monitor
  • Separate shell parts so that it's resizable and works with RTL
  • Draw window previews with CSS to avoid blurryness from CSS positioning
  • Handle solid colors and when dark picture is different from light picture
  • Follows dim setting

@danirabbit danirabbit requested a review from a team May 17, 2024 23:01
@danirabbit danirabbit mentioned this pull request May 18, 2024
Merged
zeebok
zeebok approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as specified!

@danirabbit danirabbit merged commit 830df24 into main May 18, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/wallpaper-preview branch May 18, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok