Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SettingsPage and SettingsSidebar #400

Merged
merged 6 commits into from
May 18, 2024
Merged

Use SettingsPage and SettingsSidebar #400

merged 6 commits into from
May 18, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 18, 2024 •
edited
Loading

Screenshot from 2024-05-18 08 49 58

Fixes an issue where this plugin forces the window to be vertically larger

@danirabbit danirabbit requested a review from a team May 18, 2024 15:51
@danirabbit danirabbit mentioned this pull request May 18, 2024
Merged
zeebok
zeebok previously approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment otherwise this looks good both in code and in use

src/Views/Wallpaper.vala Show resolved Hide resolved
@danirabbit danirabbit requested a review from zeebok May 18, 2024 21:32
@zeebok zeebok merged commit 9f6fe85 into main May 18, 2024
2 of 4 checks passed
@zeebok zeebok deleted the danirabbit/settingspage branch May 18, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok