linter: Check for trailing spaces at the end of lines in yaml (#1595)

Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
envoyproxy · Jun 27, 2023 · 278e02f · 278e02f
1 parent 155f75f
commit 278e02f
Show file tree

Hide file tree

Showing 116 changed files with 198 additions and 198 deletions.
diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml
@@ -86,19 +86,19 @@ jobs:
       with:
         name: envoy-gateway
         path: bin/
-    
+
     - name: Give Privileges To EG Binaries
       run: |
         chmod +x bin/linux/amd64/envoy-gateway
         chmod +x bin/linux/arm64/envoy-gateway
 
     # conformance
-    - name: Run Conformance Tests 
+    - name: Run Conformance Tests
       env:
         KIND_NODE_TAG: ${{ matrix.version }}
         IMAGE_PULL_POLICY: IfNotPresent
       run: make conformance
-  
+
   e2e-test:
     runs-on: ubuntu-latest
     needs: [build]
@@ -114,14 +114,14 @@ jobs:
       with:
         name: envoy-gateway
         path: bin/
-    
+
     - name: Give Privileges To EG Binaries
       run: |
         chmod +x bin/linux/amd64/envoy-gateway
         chmod +x bin/linux/arm64/envoy-gateway
 
     # E2E
-    - name: Run E2E Tests 
+    - name: Run E2E Tests
       env:
         KIND_NODE_TAG: ${{ matrix.version }}
         IMAGE_PULL_POLICY: IfNotPresent

diff --git a/.github/workflows/docs.yaml b/.github/workflows/docs.yaml
@@ -34,7 +34,7 @@ jobs:
       - name: Generate EG Pages
         run: make docs
 
-      # Upload docs for GitHub Pages    
+      # Upload docs for GitHub Pages
       - name: Upload GitHub Pages artifact
         uses: actions/upload-pages-artifact@v1.0.9
         with:

diff --git a/.github/workflows/latest_release.yaml b/.github/workflows/latest_release.yaml
@@ -17,7 +17,7 @@ jobs:
       run: make generate-manifests IMAGE=envoyproxy/gateway-dev TAG=latest OUTPUT_DIR=release-artifacts
 
     - name: Build egctl latest multiarch binaries
-      run: | 
+      run: |
         make build-multiarch BINS="egctl"
         tar -zcvf egctl_latest_linux_amd64.tar.gz bin/linux/amd64/
         tar -zcvf egctl_latest_linux_arm64.tar.gz bin/linux/arm64/
@@ -63,7 +63,7 @@ jobs:
           egctl_latest_darwin_arm64.tar.gz
         body: |
           This is the "latest" release of **Envoy Gateway**, which contains the most recent commits from the main branch.
-          
+
           This release **might not be stable**.
 
           It is only intended for developers wishing to try out the latest features in Envoy Gateway, some of which may not be fully implemented.
@@ -75,7 +75,7 @@ jobs:
           ```
 
     # Check if latest release and tag are created properly,
-    # if not, the workflow needs to report an error, 
+    # if not, the workflow needs to report an error,
     # let maintainers be aware of it and rerun it manually.
     # After Recreate the Latest Release and Tag, we need to sleep some time to wait
     # new tag and release are created before checking it.

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -3,7 +3,7 @@ name: Release
 on:
   push:
     # Sequence of patterns matched against refs/tags
-    tags:        
+    tags:
       - "v*.*.*"
 jobs:
   release:

diff --git a/.github/workflows/retest.yaml b/.github/workflows/retest.yaml
@@ -21,10 +21,10 @@ jobs:
             console.log(`Comment: ${comment}`);
             console.log(`Contains Trigger: ${containsTrigger}`);
             return containsTrigger;
-      
+
       - name: Install @octokit/core
         run: npm install @octokit/core@^3
-      
+
       - name: Rerun Action
         if: steps.check_comment.outputs.result == 'true'
         uses: actions/github-script@v6

diff --git a/examples/kubernetes/grpc-routing.yaml b/examples/kubernetes/grpc-routing.yaml
@@ -66,16 +66,16 @@ kind: GRPCRoute
 metadata:
   name: yages
   labels:
-    example: grpc-routing        
+    example: grpc-routing
 spec:
   parentRefs:
-    - name: example-gateway 
+    - name: example-gateway
   hostnames:
     - "grpc-example.com"
   rules:
     - backendRefs:
         - group: ""
           kind: Service
-          name: yages 
+          name: yages
           port: 9000
           weight: 1
diff --git a/examples/loki/loki.yaml b/examples/loki/loki.yaml
@@ -84,7 +84,7 @@ metadata:
     app.kubernetes.io/managed-by: Helm
 data:
   runtime-config.yaml: |
-    
+
     {}
 ---
 # Source: loki/templates/service-memberlist.yaml

diff --git a/examples/otel-collector/helm-values.yaml b/examples/otel-collector/helm-values.yaml
@@ -17,7 +17,7 @@ config:
           key: loki.attribute.labels
           # k8s.pod.name is OpenTelemetry format for Kubernetes Pod name,
           # Loki will convert this to k8s_pod_name label.
-          value: k8s.pod.name, k8s.namespace.name 
+          value: k8s.pod.name, k8s.namespace.name
   receivers:
     otlp:
       protocols:

diff --git a/internal/cmd/egctl/testdata/translate/in/default-resources.yaml b/internal/cmd/egctl/testdata/translate/in/default-resources.yaml
@@ -161,7 +161,7 @@ metadata:
   name: endpointslice-providedBackend
   namespace: default
   labels:
-    kubernetes.io/service-name: providedBackend 
+    kubernetes.io/service-name: providedBackend
 addressType: IPv4
 ports:
   - name: http

diff --git a/internal/cmd/egctl/testdata/translate/in/invalid-envoyproxy.yaml b/internal/cmd/egctl/testdata/translate/in/invalid-envoyproxy.yaml
@@ -2,7 +2,7 @@ apiVersion: config.gateway.envoyproxy.io/v1alpha1
 kind: EnvoyProxy
 metadata:
   name: example
-  namespace: default 
+  namespace: default
 spec:
   bootstrap: |
     admin:
@@ -26,7 +26,7 @@ spec:
     group: config.gateway.envoyproxy.io
     kind: EnvoyProxy
     name: example
-    namespace: default 
+    namespace: default
 ---
 apiVersion: gateway.networking.k8s.io/v1beta1
 kind: Gateway

diff --git a/internal/cmd/egctl/testdata/translate/in/valid-envoyproxy.yaml b/internal/cmd/egctl/testdata/translate/in/valid-envoyproxy.yaml
@@ -2,14 +2,14 @@ apiVersion: config.gateway.envoyproxy.io/v1alpha1
 kind: EnvoyProxy
 metadata:
   name: example
-  namespace: default 
+  namespace: default
 spec:
   provider:
     type: Kubernetes
     kubernetes:
       envoyService:
         annotations:
-          custom1: svc-annotation1 
+          custom1: svc-annotation1
 ---
 apiVersion: gateway.networking.k8s.io/v1beta1
 kind: GatewayClass
@@ -21,7 +21,7 @@ spec:
     group: config.gateway.envoyproxy.io
     kind: EnvoyProxy
     name: example
-    namespace: default 
+    namespace: default
 ---
 apiVersion: gateway.networking.k8s.io/v1beta1
 kind: Gateway

diff --git a/...nal/gatewayapi/testdata/extensions/httproute-with-extension-filter-invalid-group.out.yaml b/...nal/gatewayapi/testdata/extensions/httproute-with-extension-filter-invalid-group.out.yaml
@@ -22,7 +22,7 @@ gateways:
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
         kind: GRPCRoute
-      attachedRoutes: 0 
+      attachedRoutes: 0
       conditions:
       - type: Programmed
         status: "True"
@@ -57,7 +57,7 @@ httpRoutes:
         extensionRef:
           group: foo.example.io
           kind: Foo
-          name: test 
+          name: test
   status:
     parents:
     - parentRef:

diff --git a/...rnal/gatewayapi/testdata/extensions/httproute-with-non-matching-extension-filter.out.yaml b/...rnal/gatewayapi/testdata/extensions/httproute-with-non-matching-extension-filter.out.yaml
@@ -22,7 +22,7 @@ gateways:
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
         kind: GRPCRoute
-      attachedRoutes: 0 
+      attachedRoutes: 0
       conditions:
       - type: Programmed
         status: "True"
@@ -57,7 +57,7 @@ httpRoutes:
         extensionRef:
           group: foo.example.io
           kind: Foo
-          name: example 
+          name: example
   status:
     parents:
     - parentRef:

diff --git a/internal/gatewayapi/testdata/extensions/httproute-with-unsupported-extension-filter.out.yaml b/internal/gatewayapi/testdata/extensions/httproute-with-unsupported-extension-filter.out.yaml
@@ -22,7 +22,7 @@ gateways:
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
         kind: GRPCRoute
-      attachedRoutes: 0 
+      attachedRoutes: 0
       conditions:
       - type: Programmed
         status: "True"
@@ -57,7 +57,7 @@ httpRoutes:
         extensionRef:
           group: foo.example.io
           kind: Unsupported
-          name: test 
+          name: test
   status:
     parents:
     - parentRef:

diff --git a/internal/gatewayapi/testdata/extensions/httproute-with-valid-extension-filter.out.yaml b/internal/gatewayapi/testdata/extensions/httproute-with-valid-extension-filter.out.yaml
@@ -21,7 +21,7 @@ gateways:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
-        kind: GRPCRoute        
+        kind: GRPCRoute
       attachedRoutes: 1
       conditions:
       - type: Programmed

diff --git a/...rnal/gatewayapi/testdata/gateway-allows-same-namespace-with-disallowed-httproute.out.yaml b/...rnal/gatewayapi/testdata/gateway-allows-same-namespace-with-disallowed-httproute.out.yaml
@@ -20,7 +20,7 @@ gateways:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
-        kind: GRPCRoute        
+        kind: GRPCRoute
       attachedRoutes: 0
       conditions:
       - type: Programmed
@@ -59,9 +59,9 @@ httpRoutes:
         status: "False"
         reason: NotAllowedByListeners
         message: No listeners included by this parent ref allowed this attachment.
-      - type: ResolvedRefs 
+      - type: ResolvedRefs
         status: "True"
-        reason: ResolvedRefs 
+        reason: ResolvedRefs
         message: Resolved all the Object references for the Route
 xdsIR:
   envoy-gateway-gateway-1:

diff --git a/...gatewayapi/testdata/gateway-with-listener-with-invalid-multiple-tls-configuration.in.yaml b/...gatewayapi/testdata/gateway-with-listener-with-invalid-multiple-tls-configuration.in.yaml
@@ -19,7 +19,7 @@ gateways:
               - name: tls-secret-ecdsa-1
               - name: tls-secret-ecdsa-2
               - name: tls-secret-1
-              
+
 secrets:
   - apiVersion: v1
     kind: Secret

diff --git a/...estdata/gateway-with-two-listeners-with-http-and-tlsroute-same-hostname-and-port.out.yaml b/...estdata/gateway-with-two-listeners-with-http-and-tlsroute-same-hostname-and-port.out.yaml
@@ -30,7 +30,7 @@ gateways:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
-        kind: GRPCRoute        
+        kind: GRPCRoute
       conditions:
       - type: Conflicted
         status: "True"
@@ -81,9 +81,9 @@ httpRoutes:
         status: "False"
         reason: NoReadyListeners
         message: There are no ready listeners for this parent ref
-      - type: ResolvedRefs 
+      - type: ResolvedRefs
         status: "True"
-        reason: ResolvedRefs 
+        reason: ResolvedRefs
         message: Resolved all the Object references for the Route
 tlsRoutes:
 - apiVersion: gateway.networking.k8s.io/v1alpha2
@@ -110,9 +110,9 @@ tlsRoutes:
         status: "False"
         reason: NoReadyListeners
         message: There are no ready listeners for this parent ref
-      - type: ResolvedRefs 
+      - type: ResolvedRefs
         status: "True"
-        reason: ResolvedRefs 
+        reason: ResolvedRefs
         message: Resolved all the Object references for the Route
 xdsIR:
   envoy-gateway-gateway-1:

diff --git a/internal/gatewayapi/testdata/gateway-with-two-listeners-with-multiple-httproutes.out.yaml b/internal/gatewayapi/testdata/gateway-with-two-listeners-with-multiple-httproutes.out.yaml
@@ -28,7 +28,7 @@ gateways:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
-        kind: GRPCRoute        
+        kind: GRPCRoute
       AttachedRoutes: 2
       conditions:
       - type: Programmed
@@ -44,7 +44,7 @@ gateways:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
-        kind: GRPCRoute        
+        kind: GRPCRoute
       AttachedRoutes: 2
       conditions:
       - type: Programmed

diff --git a/internal/gatewayapi/testdata/gateway-with-two-listeners-with-same-port-and-hostname.out.yaml b/internal/gatewayapi/testdata/gateway-with-two-listeners-with-same-port-and-hostname.out.yaml
@@ -28,7 +28,7 @@ gateways:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
-        kind: GRPCRoute        
+        kind: GRPCRoute
       conditions:
       - type: Conflicted
         status: "True"
@@ -43,7 +43,7 @@ gateways:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
-        kind: GRPCRoute        
+        kind: GRPCRoute
       conditions:
       - type: Conflicted
         status: "True"
@@ -81,9 +81,9 @@ httpRoutes:
         status: "False"
         reason: NoReadyListeners
         message: There are no ready listeners for this parent ref
-      - type: ResolvedRefs 
+      - type: ResolvedRefs
         status: "True"
-        reason: ResolvedRefs 
+        reason: ResolvedRefs
         message: Resolved all the Object references for the Route
 xdsIR:
   envoy-gateway-gateway-1:

diff --git a/.../gatewayapi/testdata/gateway-with-two-listeners-with-same-port-http-udp-protocol.out.yaml b/.../gatewayapi/testdata/gateway-with-two-listeners-with-same-port-http-udp-protocol.out.yaml
@@ -27,7 +27,7 @@ gateways:
       - group: gateway.networking.k8s.io
         kind: HTTPRoute
       - group: gateway.networking.k8s.io
-        kind: GRPCRoute        
+        kind: GRPCRoute
       AttachedRoutes: 1
       conditions:
       - type: Programmed

diff --git a/internal/gatewayapi/testdata/grpcroute-with-header-match.in.yaml b/internal/gatewayapi/testdata/grpcroute-with-header-match.in.yaml
@@ -7,7 +7,7 @@ gateways:
   spec:
     gatewayClassName: envoy-gateway-class
     listeners:
-    - name: http 
+    - name: http
       protocol: HTTP
       port: 80
       allowedRoutes:
@@ -23,13 +23,13 @@ grpcRoutes:
     parentRefs:
     - namespace: envoy-gateway
       name: gateway-1
-      sectionName: http 
+      sectionName: http
     rules:
     - matches:
       - headers:
         - type: Exact
           name: magic
-          value: foo                
+          value: foo
       backendRefs:
       - name: service-1
         port: 8080
-Original file line number
+Diff line change
@@ Expand Up / @@ -3,7 +3,7 @@ name: Release @@
     on:
       push:
         # Sequence of patterns matched against refs/tags
-        tags:
+        tags:
           - "v*.*.*"
     jobs:
       release:
@@ Expand Down @@