Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go standard errors #2382

Merged
merged 1 commit into from
Jan 2, 2024

use go standard errors

229e234
Select commit
Loading
Failed to load commit list.
Merged

use go standard errors #2382

use go standard errors
229e234
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 2, 2024 in 0s

64.62% (target 60.00%)

View this Pull Request on Codecov

64.62% (target 60.00%)

Details

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (6268983) 64.64% compared to head (229e234) 64.62%.

Files Patch % Lines
internal/provider/kubernetes/controller.go 8.33% 11 Missing ⚠️
internal/infrastructure/kubernetes/infra.go 10.00% 9 Missing ⚠️
internal/xds/translator/jsonpatch.go 0.00% 8 Missing ⚠️
internal/cmd/egctl/envoy_stats.go 0.00% 6 Missing ⚠️
internal/provider/kubernetes/routes.go 0.00% 5 Missing ⚠️
internal/cmd/certgen.go 0.00% 4 Missing ⚠️
internal/infrastructure/kubernetes/infra_client.go 0.00% 2 Missing ⚠️
internal/provider/kubernetes/filters.go 0.00% 2 Missing ⚠️
internal/xds/translator/tracing.go 0.00% 2 Missing ⚠️
internal/cmd/egctl/version.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
- Coverage   64.64%   64.62%   -0.02%     
==========================================
  Files         114      114              
  Lines       16618    16618              
==========================================
- Hits        10742    10740       -2     
- Misses       5197     5199       +2     
  Partials      679      679

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov