Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add egctl experimental dashboard envoy-proxy to render the admin dashboard for the proxy #2669

Merged
merged 3 commits into from
Feb 24, 2024

revise based on comments

8bc249f
Select commit
Loading
Failed to load commit list.
Merged

feat: add egctl experimental dashboard envoy-proxy to render the admin dashboard for the proxy #2669

revise based on comments
8bc249f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 23, 2024 in 0s

63.00% (target 60.00%)

View this Pull Request on Codecov

63.00% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 0% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 63.00%. Comparing base (4c79ef9) to head (8bc249f).
Report is 7 commits behind head on main.

Files Patch % Lines
internal/cmd/egctl/envoy_dashboard.go 0.00% 98 Missing ⚠️
internal/cmd/egctl/dashboard.go 0.00% 11 Missing ⚠️
internal/cmd/egctl/experimental.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
- Coverage   63.38%   63.00%   -0.39%     
==========================================
  Files         119      121       +2     
  Lines       19098    19574     +476     
==========================================
+ Hits        12106    12332     +226     
- Misses       6193     6441     +248     
- Partials      799      801       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.