Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated http filters for ExtAuth #2893

Merged
merged 4 commits into from
Mar 15, 2024

Merge branch 'main' into remove-duplicated-filters

9f8ba6c
Select commit
Loading
Failed to load commit list.
Merged

Remove duplicated http filters for ExtAuth #2893

Merge branch 'main' into remove-duplicated-filters
9f8ba6c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 15, 2024 in 0s

64.56% (target 60.00%)

View this Pull Request on Codecov

64.56% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.56%. Comparing base (975ef6e) to head (9f8ba6c).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/gatewayapi/securitypolicy.go 88.88% 0 Missing and 1 partial ⚠️
internal/xds/translator/basicauth.go 50.00% 0 Missing and 1 partial ⚠️
internal/xds/translator/extauth.go 90.00% 0 Missing and 1 partial ⚠️
internal/xds/translator/oidc.go 66.66% 0 Missing and 1 partial ⚠️
internal/xds/translator/utils.go 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
+ Coverage   64.52%   64.56%   +0.03%     
==========================================
  Files         122      122              
  Lines       21092    21106      +14     
==========================================
+ Hits        13610    13627      +17     
+ Misses       6634     6632       -2     
+ Partials      848      847       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov