chore: make clean should clean tools/bin #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
==========================================
- Coverage 64.59% 64.57% -0.02%
==========================================
Files 122 122
Lines 21115 21115
==========================================
- Hits 13640 13636 -4
- Misses 6629 6632 +3
- Partials 846 847 +1 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Mar 16, 2024
There was a problem hiding this comment.
lets add a tools.clean and add this rm under it, with the definition living under
https://github.com/envoyproxy/gateway/blob/main/tools/make/tools.mk
arkodg
reviewed
Mar 17, 2024
| rm -rf $(tools.bindir) | ||
|
|
||
| .PHONY: clean | ||
| clean: ## Remove all files that are created during builds. |
There was a problem hiding this comment.
umm there's already a clean target under go.mk
There was a problem hiding this comment.
there's another one in docs.mk, just follow the old way.
There was a problem hiding this comment.
ah so make clean will call all of them ?
arkodg
approved these changes
Mar 17, 2024
shawnh2
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.