Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make clean should clean tools/bin #2945

Merged
merged 3 commits into from
Mar 18, 2024
Merged

chore: make clean should clean tools/bin #2945

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a35299
chore: make clean should clean tools/bin
zirain Mar 16, 2024
5a6cab8
update
zirain Mar 16, 2024
2aa1ae5
Merge branch 'main' into make-clean
zirain Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tools/make/tools.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,11 @@ tools/bin/$(notdir $(SHELLCHECK_TXZ)):
mkdir -p $(@D)
tar -C $(@D) -Jxmf $< --strip-components=1 shellcheck-v$(SHELLCHECK_VERSION)/shellcheck
endif

tools.clean: # Remove all tools
@$(LOG_TARGET)
rm -rf $(tools.bindir)

.PHONY: clean
clean: ## Remove all files that are created during builds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm there's already a clean target under go.mk

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's another one in docs.mk, just follow the old way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah so make clean will call all of them ?

clean: tools.clean
Loading