Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: renames user guides to tasks #3104

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

eitansuez
Copy link
Contributor

@eitansuez eitansuez commented Apr 6, 2024

Fixes #3098

@eitansuez eitansuez requested a review from a team as a code owner April 6, 2024 15:41
@eitansuez eitansuez force-pushed the rename-userguides-to-tasks branch from 8ea1481 to fa55f5b Compare April 6, 2024 15:42
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.57%. Comparing base (29946b0) to head (1b0f52b).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3104      +/-   ##
==========================================
+ Coverage   66.51%   66.57%   +0.06%     
==========================================
  Files         161      161              
  Lines       22673    22693      +20     
==========================================
+ Hits        15080    15107      +27     
+ Misses       6720     6714       -6     
+ Partials      873      872       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eitansuez
Copy link
Contributor Author

this commit is a starting point. there are broken links that i'll try to chase down. probably due to renaming the user/ folder to tasks/. i tried to revise the links in latest/ but not retroactively, that could be the issue. feel free to reject this PR if you think this goes down the wrong path.

@zirain zirain changed the title renames user guides to tasks, #3098 docs: renames user guides to tasks Apr 6, 2024
zirain
zirain previously approved these changes Apr 6, 2024
@eitansuez
Copy link
Contributor Author

some markdowns reference published docs, so they can't yet reference the tasks/ folder - in order to pass the link check. after this is merged, they'll need to be updated.

@eitansuez eitansuez force-pushed the rename-userguides-to-tasks branch 3 times, most recently from 32cf8b8 to 751382f Compare April 8, 2024 15:03
@eitansuez
Copy link
Contributor Author

ok, the link check now passes, i just reviewed the diffs. i think this PR is good.

Eitan Suez added 3 commits April 8, 2024 14:52
Signed-off-by: Eitan Suez <eitan@tetrate.io>
Signed-off-by: Eitan Suez <eitan@tetrate.io>
Signed-off-by: Eitan Suez <eitan@tetrate.io>
@eitansuez eitansuez force-pushed the rename-userguides-to-tasks branch from 751382f to 1b0f52b Compare April 8, 2024 19:52
@eitansuez
Copy link
Contributor Author

i suspect re-running the build will make it pass.

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Apr 9, 2024

/retest

@eitansuez
Copy link
Contributor Author

This pr is ready to merge

@zirain zirain requested a review from Xunzhuo April 9, 2024 05:01
@Xunzhuo Xunzhuo merged commit ff5a0b1 into envoyproxy:main Apr 9, 2024
22 checks passed
@arkodg
Copy link
Contributor

arkodg commented Apr 9, 2024

hey @eitansuez can we also include this in v1.0 ?

@zirain zirain mentioned this pull request Apr 9, 2024
@eitansuez
Copy link
Contributor Author

hey @eitansuez can we also include this in v1.0 ?

Yes certainly. I'll get working on that.

@eitansuez eitansuez deleted the rename-userguides-to-tasks branch April 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "user guides" to "tasks"
5 participants