Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update golint #3177

Merged
merged 2 commits into from
Apr 12, 2024
Merged

chore: update golint #3177

merged 2 commits into from
Apr 12, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 11, 2024

No description provided.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner April 11, 2024 08:52
Signed-off-by: zirain <zirain2009@gmail.com>
@@ -28,6 +28,10 @@ import (
var c client.Client

func TestMain(m *testing.M) {
Copy link
Contributor Author

@zirain zirain Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks golint! This fix a memory leak when cel test failed.

@zirain
Copy link
Contributor Author

zirain commented Apr 11, 2024

/retest

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 92b4a9b into envoyproxy:main Apr 12, 2024
17 checks passed
@zirain zirain deleted the golint branch April 12, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants