feat: support HTTP compression on stats/prometheus #3201
Conversation
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
|
we should reuse the struct from https://github.com/envoyproxy/gateway/blob/main/api/v1alpha1/compression_types.go |
|
since this translation may get complex, probably makes sense to generate a go struct, marshal into YAML and append that into the bootstrap |
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
|
is the test flaky? |
|
/retest |
1 similar comment
|
/retest |
|
@zirain let me know if we can merge this. |
|
@arkodg PTAL when you're back. |
| @@ -79,4 +79,7 @@ type ProxyOpenTelemetrySink struct { | |||
| type ProxyPrometheusProvider struct { | |||
| // Disable the Prometheus endpoint. | |||
| Disable bool `json:"disable,omitempty"` | |||
| // Configure the compression on Prometheus endpoint. Compression is useful in situations when bandwidth is scarce and large payloads can be effectively compressed at the expense of higher CPU load. | |||
| // +optional | |||
| Compression *Compression `json:"compression,omitempty"` | |||
There was a problem hiding this comment.
the BTP API instantiated this as a list
to support multiple compression settings, to support heterogenous clients (and compression settings), do we also need to make it a list here ?There was a problem hiding this comment.
could 1 envoy route support multiple compression libraries? AFAIK we need to select only 1 library right?
There was a problem hiding this comment.
make it to list but limit maxitem to 1?
There was a problem hiding this comment.
that doesn't make sense IMO
There was a problem hiding this comment.
I think envoy can support multiple compressor libraries per route, which is the argument for making it a list
but realistically the persona who creates the EnvoyProxy resource with this setting, also knows beforehand the compression supported by the peer, so a single scalar value is fine here
What type of PR is this?
envoy gateway expose prometheus format metrics on /stats/prometheus. prometheus query this endpoints and there are network cost between prometheus & envoy gateway.
add HTTP compression support for gzip, brotli, zstd
What this PR does / why we need it:
add HTTP compression support on /stats/prometheus
reduce network cost for getting the gateway metrics
Which issue(s) this PR fixes:
#3200